Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Jakub Sitnicki
On Wed, Jun 24, 2020 at 08:24 PM CEST, Andrii Nakryiko wrote: > On Wed, Jun 24, 2020 at 11:16 AM Jakub Sitnicki wrote: >> >> On Wed, Jun 24, 2020 at 07:47 PM CEST, Andrii Nakryiko wrote: >> > On Wed, Jun 24, 2020 at 10:19 AM Jakub Sitnicki >> > wrote: >> >> >> >> On Tue, Jun 23, 2020 at 12:34 PM

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Andrii Nakryiko
On Wed, Jun 24, 2020 at 11:16 AM Jakub Sitnicki wrote: > > On Wed, Jun 24, 2020 at 07:47 PM CEST, Andrii Nakryiko wrote: > > On Wed, Jun 24, 2020 at 10:19 AM Jakub Sitnicki > > wrote: > >> > >> On Tue, Jun 23, 2020 at 12:34 PM CEST, Jakub Sitnicki wrote: > >> > Prepare for having multi-prog atta

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Jakub Sitnicki
On Wed, Jun 24, 2020 at 07:47 PM CEST, Andrii Nakryiko wrote: > On Wed, Jun 24, 2020 at 10:19 AM Jakub Sitnicki wrote: >> >> On Tue, Jun 23, 2020 at 12:34 PM CEST, Jakub Sitnicki wrote: >> > Prepare for having multi-prog attachments for new netns attach types by >> > storing programs to run in a b

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Andrii Nakryiko
On Wed, Jun 24, 2020 at 10:19 AM Jakub Sitnicki wrote: > > On Tue, Jun 23, 2020 at 12:34 PM CEST, Jakub Sitnicki wrote: > > Prepare for having multi-prog attachments for new netns attach types by > > storing programs to run in a bpf_prog_array, which is well suited for > > iterating over programs

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Jakub Sitnicki
On Tue, Jun 23, 2020 at 11:24 PM CEST, Martin KaFai Lau wrote: > On Tue, Jun 23, 2020 at 10:59:37PM +0200, Jakub Sitnicki wrote: >> On Tue, Jun 23, 2020 at 09:33 PM CEST, Martin KaFai Lau wrote: >> > On Tue, Jun 23, 2020 at 12:34:58PM +0200, Jakub Sitnicki wrote: >> > >> > [ ... ] >> > >> >> @@ -93

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-24 Thread Jakub Sitnicki
On Tue, Jun 23, 2020 at 12:34 PM CEST, Jakub Sitnicki wrote: > Prepare for having multi-prog attachments for new netns attach types by > storing programs to run in a bpf_prog_array, which is well suited for > iterating over programs and running them in sequence. > > Because bpf_prog_array is dynami

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-23 Thread Martin KaFai Lau
On Tue, Jun 23, 2020 at 10:59:37PM +0200, Jakub Sitnicki wrote: > On Tue, Jun 23, 2020 at 09:33 PM CEST, Martin KaFai Lau wrote: > > On Tue, Jun 23, 2020 at 12:34:58PM +0200, Jakub Sitnicki wrote: > > > > [ ... ] > > > >> @@ -93,8 +108,16 @@ static int bpf_netns_link_update_prog(struct bpf_link >

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-23 Thread Jakub Sitnicki
On Tue, Jun 23, 2020 at 09:33 PM CEST, Martin KaFai Lau wrote: > On Tue, Jun 23, 2020 at 12:34:58PM +0200, Jakub Sitnicki wrote: > > [ ... ] > >> @@ -93,8 +108,16 @@ static int bpf_netns_link_update_prog(struct bpf_link >> *link, >> goto out_unlock; >> } >> >> +run_array = rc

Re: [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array

2020-06-23 Thread Martin KaFai Lau
On Tue, Jun 23, 2020 at 12:34:58PM +0200, Jakub Sitnicki wrote: [ ... ] > @@ -93,8 +108,16 @@ static int bpf_netns_link_update_prog(struct bpf_link > *link, > goto out_unlock; > } > > + run_array = rcu_dereference_protected(net->bpf.run_array[type], > +