Re: [PATCH bpf-next v2] net: Don't call XDP_SETUP_PROG when nothing is changed

2019-08-17 Thread Daniel Borkmann
On 8/14/19 4:34 PM, Maxim Mikityanskiy wrote: Don't uninstall an XDP program when none is installed, and don't install an XDP program that has the same ID as the one already installed. dev_change_xdp_fd doesn't perform any checks in case it uninstalls an XDP program. It means that the driver's n

Re: [PATCH bpf-next v2] net: Don't call XDP_SETUP_PROG when nothing is changed

2019-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2019 14:34:06 +, Maxim Mikityanskiy wrote: > Don't uninstall an XDP program when none is installed, and don't install > an XDP program that has the same ID as the one already installed. > > dev_change_xdp_fd doesn't perform any checks in case it uninstalls an > XDP program. It m

Re: [PATCH bpf-next v2] net: Don't call XDP_SETUP_PROG when nothing is changed

2019-08-14 Thread Jonathan Lemon
On 14 Aug 2019, at 7:34, Maxim Mikityanskiy wrote: > Don't uninstall an XDP program when none is installed, and don't install > an XDP program that has the same ID as the one already installed. > > dev_change_xdp_fd doesn't perform any checks in case it uninstalls an > XDP program. It means tha