Re: [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 5/27/20 4:01 AM, Toke Høiland-Jørgensen wrote: >> Did you give any special consideration to where the hook should be? I'm >> asking because my immediate thought was that it should be on flush >> (i.e., in bq_xmit_all()), but now that I see this I'm so sure anymore. >> Wha

Re: [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry

2020-05-27 Thread David Ahern
On 5/27/20 4:01 AM, Toke Høiland-Jørgensen wrote: > Did you give any special consideration to where the hook should be? I'm > asking because my immediate thought was that it should be on flush > (i.e., in bq_xmit_all()), but now that I see this I'm so sure anymore. > What were your thoughts around

Re: [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > Add BPF_XDP_DEVMAP attach type for use with programs associated with a > DEVMAP entry. > > DEVMAPs can associate a program with a device entry by setting the > value to pair. The program associated with the fd must have > type XDP with expected attach type BPF_XDP_DEVMAP. W