Re: [PATCH bpf] bpf: fix 32-bit divide by zero

2018-01-18 Thread Daniel Borkmann
On 01/18/2018 11:40 PM, Alexei Starovoitov wrote: > On 1/18/18 2:30 PM, Eric Dumazet wrote: >> On Fri, 2018-01-12 at 18:59 -0800, Alexei Starovoitov wrote: >>> due to some JITs doing if (src_reg == 0) check in 64-bit mode >>> for div/mod opreations mask upper 32-bits of src register >>> before doin

Re: [PATCH bpf] bpf: fix 32-bit divide by zero

2018-01-18 Thread Alexei Starovoitov
On 1/18/18 2:30 PM, Eric Dumazet wrote: On Fri, 2018-01-12 at 18:59 -0800, Alexei Starovoitov wrote: due to some JITs doing if (src_reg == 0) check in 64-bit mode for div/mod opreations mask upper 32-bits of src register before doing the check Is the plan to fix JIT, and if they can all be fi

Re: [PATCH bpf] bpf: fix 32-bit divide by zero

2018-01-18 Thread Eric Dumazet
On Fri, 2018-01-12 at 18:59 -0800, Alexei Starovoitov wrote: > due to some JITs doing if (src_reg == 0) check in 64-bit mode > for div/mod opreations mask upper 32-bits of src register > before doing the check > Is the plan to fix JIT, and if they can all be fixed, revert this patch ? x86 patch

Re: [PATCH bpf] bpf: fix 32-bit divide by zero

2018-01-14 Thread Daniel Borkmann
On 01/13/2018 03:59 AM, Alexei Starovoitov wrote: > due to some JITs doing if (src_reg == 0) check in 64-bit mode > for div/mod opreations mask upper 32-bits of src register > before doing the check > > Fixes: 622582786c9e ("net: filter: x86: internal BPF JIT") > Fixes: 7a12b5031c6b ("sparc64: Add

Re: [PATCH bpf] bpf: fix 32-bit divide by zero

2018-01-13 Thread Alexei Starovoitov
On Fri, Jan 12, 2018 at 06:59:52PM -0800, Alexei Starovoitov wrote: > due to some JITs doing if (src_reg == 0) check in 64-bit mode > for div/mod opreations mask upper 32-bits of src register > before doing the check > > Fixes: 622582786c9e ("net: filter: x86: internal BPF JIT") > Fixes: 7a12b5031