Re: [PATCH V3 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-05-01 Thread Soheil Hassas Yeganeh
On Tue, May 1, 2018 at 2:34 PM, David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Tue, 1 May 2018 10:11:27 -0400 > >> +static inline int tcp_inq_hint(struct sock *sk) > > Please do not use 'inline' in foo.c files, let the compiler decide. > > Otherwise looks great, thanks. Oops, sorry a

Re: [PATCH V3 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-05-01 Thread David Miller
From: Soheil Hassas Yeganeh Date: Tue, 1 May 2018 10:11:27 -0400 > +static inline int tcp_inq_hint(struct sock *sk) Please do not use 'inline' in foo.c files, let the compiler decide. Otherwise looks great, thanks.