Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 01:00:54AM +0530, Sumera Priyadarsini wrote: > Every iteration of for_each_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no dec

Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Mon, 24 Aug 2020 01:00:54 +0530 > --- > > Signed-off-by: Sumera Priyadarsini > > Signed-off-by: Sumera Priyadarsini You only need one Signed-off-by: You must not put the signoff after the "---" otherwise GIT will remove it from the commit log message when I t