Re: [PATCH RFC] b43: stop hardcoding LED behavior

2016-04-25 Thread Michael Büsch
On Mon, 25 Apr 2016 20:21:36 +0200 Lucas Stach wrote: > > Numbers please. Did you measure that is actually causes more > > _wakeups_? > > How many? > > The led work is placed in the mac80211 workqueue and LED updates only > > happen on behalf of mac80211 activities (by default). It only causes >

Re: [PATCH RFC] b43: stop hardcoding LED behavior

2016-04-25 Thread Lucas Stach
Am Montag, den 25.04.2016, 17:53 +0200 schrieb Michael Büsch: > On Mon, 25 Apr 2016 09:40:51 +0200 > Lucas Stach wrote: > > > > > On my system the SPROM correctly defines the only wired LED (radio) > > but > > skips all others, leading to the hardcode to register LEDs with RX > > and TX > > trig

Re: [PATCH RFC] b43: stop hardcoding LED behavior

2016-04-25 Thread Michael Büsch
On Mon, 25 Apr 2016 09:40:51 +0200 Lucas Stach wrote: > On my system the SPROM correctly defines the only wired LED (radio) but > skips all others, leading to the hardcode to register LEDs with RX and TX > triggers. Hm ok. It probably is a good idea to change the condition from if (sprom[led_in