Re: [PATCH NET 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-22 Thread Yunsheng Lin
Hi, Andrew On 2017/6/23 11:16, Andrew Lunn wrote: >> +int genphy_loopback(struct phy_device *phydev, bool enable) >> +{ >> +int value; >> + >> +if (enable) { >> +value = phy_read(phydev, MII_BMCR); >> +phy_write(phydev, MII_BMCR, value | BMCR_LOOPBACK); >> +} el

Re: [PATCH NET 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-22 Thread Andrew Lunn
> +int genphy_loopback(struct phy_device *phydev, bool enable) > +{ > + int value; > + > + if (enable) { > + value = phy_read(phydev, MII_BMCR); > + phy_write(phydev, MII_BMCR, value | BMCR_LOOPBACK); > + } else { > + value = phy_read(phydev, MII_BMCR