Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

2007-06-13 Thread Mithlesh Thukral
On Wednesday 13 June 2007 10:18, Dhananjay Phadke wrote: > Mithlesh, > > You don't initialize max_mc_count anywhere. The multicast address pool > can hold 16 addresses for ports {0,1} and 4 for ports {2,3}. You should > have following line in the probe routine. > > > adapter->max_mc_count = (adapte

Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

2007-06-12 Thread Dhananjay Phadke
Mithlesh, You don't initialize max_mc_count anywhere. The multicast address pool can hold 16 addresses for ports {0,1} and 4 for ports {2,3}. You should have following line in the probe routine. > adapter->max_mc_count = (adapter->portnum > 1) ? 4 : 16; -- Dhananjay Phadke NetXen Inc. Mithlesh

Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

2007-06-10 Thread Michael Buesch
On Sunday 10 June 2007 11:54:11 Michael Buesch wrote: > > +int netxen_nic_set_mcast_addr(struct netxen_adapter *adapter, int index, > > + u8 *addr) > > +{ > > + u32 hi = 0; > > + u32 lo = 0; > > + u16 port = physical_port[adapter->portnum]; > > + > > + hi = (u32)

Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

2007-06-10 Thread Michael Buesch
On Thursday 07 June 2007 13:34:37 Mithlesh Thukral wrote: > NetXen: Add multi cast filter code > This patch adds multi cast filter code to NetXen NIC driver. > It also adds capabilities to setup the multicast address in hardware > from the host side. > +int netxen_nic_enable_mcast_filter(struct ne