Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: > > A patch to use ARRAY_SIZE macro already defined in kernel.h. > > OK, but checks you're changing are strange. idx there is signed so > > BUG_ON(idx < 0 ||

Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Alexey Dobriyan
On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: > A patch to use ARRAY_SIZE macro already defined in kernel.h. OK, but checks you're changing are strange. idx there is signed so BUG_ON(idx < 0 || idx > ARRAY_SIZE()); should be more appropriate. > --- a/drivers/net/ibm_