Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-21 Thread Steffen Klassert
On Fri, Apr 21, 2017 at 01:29:34PM +0800, Herbert Xu wrote: > On Thu, Apr 20, 2017 at 12:50:29PM +0200, Steffen Klassert wrote: > > On Thu, Apr 20, 2017 at 05:52:35PM +0800, Herbert Xu wrote: > > > On Thu, Apr 20, 2017 at 11:17:52AM +0200, Steffen Klassert wrote: > > > > > > > > I tried to use asyn

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 12:50:29PM +0200, Steffen Klassert wrote: > On Thu, Apr 20, 2017 at 05:52:35PM +0800, Herbert Xu wrote: > > On Thu, Apr 20, 2017 at 11:17:52AM +0200, Steffen Klassert wrote: > > > > > > I tried to use async algorithms but it lead to serveral problems. > > > The GSO layer can

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Steffen Klassert
On Thu, Apr 20, 2017 at 05:52:35PM +0800, Herbert Xu wrote: > On Thu, Apr 20, 2017 at 11:17:52AM +0200, Steffen Klassert wrote: > > > > I tried to use async algorithms but it lead to serveral problems. > > The GSO layer can't handle async returns, we'd need callbacks > > for all the GSO handlers. A

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 11:17:52AM +0200, Steffen Klassert wrote: > > I tried to use async algorithms but it lead to serveral problems. > The GSO layer can't handle async returns, we'd need callbacks > for all the GSO handlers. Also we need something where we can > requeue packets if the driver is

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Steffen Klassert
On Thu, Apr 20, 2017 at 05:06:17PM +0800, Herbert Xu wrote: > On Thu, Apr 20, 2017 at 10:55:10AM +0200, Steffen Klassert wrote: > > We need a fallback algorithm for crypto offloading to a NIC. > > This is because packets can be rerouted to other NICs that > > don't support crypto offloading. The fa

Re: [PATCH 11/16] esp: Use a synchronous crypto algorithm on offloading.

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 10:55:10AM +0200, Steffen Klassert wrote: > We need a fallback algorithm for crypto offloading to a NIC. > This is because packets can be rerouted to other NICs that > don't support crypto offloading. The fallback is going to be > implemented at layer2 where we know the fina