On Mon, 29 Jul 2019 14:53:45 -0700, Jonathan Lemon wrote:
> On 29 Jul 2019, at 14:25, Jakub Kicinski wrote:
>
> > On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote:
> I realize you're following the existing code, but should we perhaps
> use
> the latest kdoc syntax? '()' af
On 29 Jul 2019, at 14:25, Jakub Kicinski wrote:
> On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote:
I realize you're following the existing code, but should we perhaps
use
the latest kdoc syntax? '()' after function name, and args should have
'@' prefix, '%' would be
On 29 Jul 2019, at 14:22, Jakub Kicinski wrote:
On Mon, 29 Jul 2019 14:02:21 -0700, Jonathan Lemon wrote:
On 29 Jul 2019, at 13:50, Jakub Kicinski wrote:
On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote:
Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(),
and skb_frag_off_s
On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote:
> > > I realize you're following the existing code, but should we perhaps
> > > use
> > > the latest kdoc syntax? '()' after function name, and args should have
> > > '@' prefix, '%' would be for constants.
> >
> > That would be a task
From: Jakub Kicinski
Date: Mon, 29 Jul 2019 14:22:11 -0700
> There is no need to ponder the connotations of verbs. Please just
> look at other function names in skbuff.h, especially those which
> copy fields :)
>
> static inline void skb_copy_hash(struct sk_buff *to, const struct sk_buff
> *f
On Mon, 29 Jul 2019 14:02:21 -0700, Jonathan Lemon wrote:
> On 29 Jul 2019, at 13:50, Jakub Kicinski wrote:
> > On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote:
> >> Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(),
> >> and skb_frag_off_set_from() accessors for page_offset.
>
On 29 Jul 2019, at 13:50, Jakub Kicinski wrote:
On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote:
Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(),
and skb_frag_off_set_from() accessors for page_offset.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 61
+
On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote:
> Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(),
> and skb_frag_off_set_from() accessors for page_offset.
>
> Signed-off-by: Jonathan Lemon
> ---
> include/linux/skbuff.h | 61 ++
> 1 f
