Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-23 Thread Ben Greear
On 04/22/2018 02:15 PM, Roopa Prabhu wrote: On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: From: Johannes Berg Date: Thu, 19 Apr 2018 17:26:57 +0200 On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: Maybe this could be in followup patches? It's going to touch a lot of files, and

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-23 Thread Ben Greear
On 04/22/2018 11:54 AM, David Miller wrote: From: Johannes Berg Date: Thu, 19 Apr 2018 17:26:57 +0200 On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: Maybe this could be in followup patches? It's going to touch a lot of files, and might be hell to get merged all at once, and I've never

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-22 Thread Roopa Prabhu
On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: > From: Johannes Berg > Date: Thu, 19 Apr 2018 17:26:57 +0200 > >> On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: >>> >>> Maybe this could be in followup patches? It's going to touch a lot of >>> files, >>> and might be hell to get mer

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-22 Thread David Miller
From: Johannes Berg Date: Thu, 19 Apr 2018 17:26:57 +0200 > On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: >> >> Maybe this could be in followup patches? It's going to touch a lot of files, >> and might be hell to get merged all at once, and I've never used spatch, so >> just maybe someon

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread Johannes Berg
On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: > > In order to efficiently parse lots of stats over and over again, I probe > the stat names once on startup, map them to the variable I am trying to use > (since different drivers may have different names for the same basic stat), > and then I

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread Ben Greear
On 04/18/2018 11:38 PM, Johannes Berg wrote: On Wed, 2018-04-18 at 14:51 -0700, Ben Greear wrote: It'd be pretty hard to know which flags are firmware stats? Yes, it is, but ethtool stats are difficult to understand in a generic manner anyway, so someone using them is already likely aware o

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Johannes Berg
On Wed, 2018-04-18 at 14:51 -0700, Ben Greear wrote: > > It'd be pretty hard to know which flags are firmware stats? > > Yes, it is, but ethtool stats are difficult to understand in a generic > manner anyway, so someone using them is already likely aware of low-level > details of the driver(s) th

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Ben Greear
On 04/18/2018 02:26 PM, Johannes Berg wrote: On Tue, 2018-04-17 at 18:49 -0700, gree...@candelatech.com wrote: + * @get_ethtool_stats2: Return extended statistics about the device. + * This is only useful if the device maintains statistics not + * included in &struct rtnl_link_stats64.

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Johannes Berg
On Tue, 2018-04-17 at 18:49 -0700, gree...@candelatech.com wrote: > > + * @get_ethtool_stats2: Return extended statistics about the device. > + * This is only useful if the device maintains statistics not > + * included in &struct rtnl_link_stats64. > + * Takes a flags argument: 0 means

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-18 Thread Florian Fainelli
On 04/17/2018 06:49 PM, gree...@candelatech.com wrote: > From: Ben Greear > > This is similar to ETHTOOL_GSTATS, but it allows you to specify > flags. These flags can be used by the driver to decrease the > amount of stats refreshed. In particular, this helps with ath10k > since getting the fir