Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API

2019-06-28 Thread Jesper Dangaard Brouer
On Fri, 28 Jun 2019 20:19:34 +0300 Ilias Apalodimas wrote: > Hi David, > > > >> Use page_pool and it's DMA mapping capabilities for Rx buffers instead > > >> of netdev/napi_alloc_frag() > > >> > > >> Although this will result in a slight performance penalty on small sized > > >> packets (~10%)

Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API

2019-06-28 Thread Ilias Apalodimas
Hi David, > >> Use page_pool and it's DMA mapping capabilities for Rx buffers instead > >> of netdev/napi_alloc_frag() > >> > >> Although this will result in a slight performance penalty on small sized > >> packets (~10%) the use of the API will allow to easily add XDP support. > >> The penalty

Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API

2019-06-28 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 28 Jun 2019 15:04:34 +0200 > On Fri, 28 Jun 2019 13:39:13 +0300 > Ilias Apalodimas wrote: > >> Use page_pool and it's DMA mapping capabilities for Rx buffers instead >> of netdev/napi_alloc_frag() >> >> Although this will result in a slight performance p

Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API

2019-06-28 Thread Jesper Dangaard Brouer
On Fri, 28 Jun 2019 13:39:13 +0300 Ilias Apalodimas wrote: > Use page_pool and it's DMA mapping capabilities for Rx buffers instead > of netdev/napi_alloc_frag() > > Although this will result in a slight performance penalty on small sized > packets (~10%) the use of the API will allow to easily

Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API

2019-06-28 Thread Jesper Dangaard Brouer
On Fri, 28 Jun 2019 13:39:13 +0300 Ilias Apalodimas wrote: > @@ -1079,11 +1095,22 @@ static int netsec_setup_rx_dring(struct netsec_priv > *priv) > } > > netsec_rx_fill(priv, 0, DESC_NUM); > + err = xdp_rxq_info_reg(&dring->xdp_rxq, priv->ndev, 0); > + if (err) > +