Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 1:57 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:40:22AM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m@gmail.com wrote: > > > > From: Tonghao Zh

Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 09:40:22AM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin wrote: > > > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > Open vSwitch and Linux bridge will disable LRO of the

Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Tonghao Zhang
On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin wrote: > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO,

Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Michael S. Tsirkin
On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Open vSwitch and Linux bridge will disable LRO of the interface > when this interface added to them. Now when disable the LRO, the > virtio-net csum is disable too. That drops the forwarding perfor

Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Tonghao Zhang
On Mon, Sep 28, 2020 at 4:35 PM Willem de Bruijn wrote: > > On Mon, Sep 28, 2020 at 5:41 AM wrote: > > > > From: Tonghao Zhang > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disab

Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

2020-09-28 Thread Willem de Bruijn
On Mon, Sep 28, 2020 at 5:41 AM wrote: > > From: Tonghao Zhang > > Open vSwitch and Linux bridge will disable LRO of the interface > when this interface added to them. Now when disable the LRO, the > virtio-net csum is disable too. That drops the forwarding performance. > > Fixes: e59ff2c49ae1 ("