Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-25 Thread Zhu Yanjun
在 2024/1/26 11:11, Zhu Yanjun 写道: 在 2024/1/22 15:02, Xuan Zhuo 写道: On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang wrote: On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote: On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo wrote: On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote: On Mon, Ja

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-22 Thread Xuan Zhuo
On Mon, 22 Jan 2024 16:32:46 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 4:04 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 15:57:08 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-22 Thread Jason Wang
On Mon, Jan 22, 2024 at 4:04 PM Xuan Zhuo wrote: > > On Mon, 22 Jan 2024 15:57:08 +0800, Jason Wang wrote: > > On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang > > > wrote: > > > > On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo > > >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-22 Thread Xuan Zhuo
On Mon, 22 Jan 2024 15:57:08 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 3:36 PM Xuan Zhuo wrote: > > On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang wrote: > > On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang > > > wrote: > > > > On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Xuan Zhuo
On Mon, 22 Jan 2024 15:19:12 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote: > > > > > > > > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo > > > > wrot

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 3:07 PM Xuan Zhuo wrote: > > On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang wrote: > > On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote: > > > > > > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Xuan Zhuo
On Mon, 22 Jan 2024 14:58:09 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote: > > > > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang > > > wrote: > > > > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Xuan Zhuo
On Mon, 22 Jan 2024 14:55:46 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 2:55 PM Jason Wang wrote: > > On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 2:20 PM Xuan Zhuo wrote: > > On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote: > > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang > > > wrote: > > > > On Mon, Jan 22, 2024 at 10:12 AM Zhu Yanjun >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Xuan Zhuo
On Mon, 22 Jan 2024 12:16:27 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo wrote: > > > > On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang wrote: > > > On Mon, Jan 22, 2024 at 10:12 AM Zhu Yanjun wrote: > > > > > > > > > > > > 在 2024/1/20 1:29, Andrew Lunn 写道: > > > >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Heng Qi
在 2024/1/22 上午11:08, Jason Wang 写道: On Fri, Jan 19, 2024 at 10:27 PM Heng Qi wrote: 在 2024/1/18 下午8:01, Zhu Yanjun 写道: 在 2024/1/16 20:04, Paolo Abeni 写道: On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: From: Zhu Yanjun Some devices emulate the virtio_net hardwares. When virtio_ne

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 12:00 PM Xuan Zhuo wrote: > > On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang wrote: > > On Mon, Jan 22, 2024 at 10:12 AM Zhu Yanjun wrote: > > > > > > > > > 在 2024/1/20 1:29, Andrew Lunn 写道: > > > >while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > > -

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Xuan Zhuo
On Mon, 22 Jan 2024 11:14:30 +0800, Jason Wang wrote: > On Mon, Jan 22, 2024 at 10:12 AM Zhu Yanjun wrote: > > > > > > 在 2024/1/20 1:29, Andrew Lunn 写道: > > >while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > - !virtqueue_is_broken(vi->cvq)) > > > + !virtque

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 22, 2024 at 10:12 AM Zhu Yanjun wrote: > > > 在 2024/1/20 1:29, Andrew Lunn 写道: > >while (!virtqueue_get_buf(vi->cvq, &tmp) && > > - !virtqueue_is_broken(vi->cvq)) > > + !virtqueue_is_broken(vi->cvq)) { > > +if (timeout) > > +

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Fri, Jan 19, 2024 at 10:27 PM Heng Qi wrote: > > > > 在 2024/1/18 下午8:01, Zhu Yanjun 写道: > > > > 在 2024/1/16 20:04, Paolo Abeni 写道: > >> On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: > >>> From: Zhu Yanjun > >>> > >>> Some devices emulate the virtio_net hardwares. When virtio_net > >>> d

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Jason Wang
On Mon, Jan 15, 2024 at 6:22 PM Zhu Yanjun wrote: > > > 在 2024/1/15 10:20, Jason Wang 写道: > > On Mon, Jan 15, 2024 at 9:35 AM Zhu Yanjun wrote: > > From: Zhu Yanjun > > Some devices emulate the virtio_net hardwares. When virtio_net > driver sends commands to the emulated hardware, normally the >

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-21 Thread Zhu Yanjun
在 2024/1/20 1:29, Andrew Lunn 写道:   while (!virtqueue_get_buf(vi->cvq, &tmp) && -   !virtqueue_is_broken(vi->cvq)) +   !virtqueue_is_broken(vi->cvq)) { +    if (timeout) +    timeout--; This is not really a timeout, just a loop counter. 200 iterations could be

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Zhu Yanjun
在 2024/1/20 1:29, Andrew Lunn 写道:   while (!virtqueue_get_buf(vi->cvq, &tmp) && -   !virtqueue_is_broken(vi->cvq)) +   !virtqueue_is_broken(vi->cvq)) { +    if (timeout) +    timeout--; This is not really a timeout, just a loop counter. 200 iterations could be

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Andrew Lunn
> > > >   while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > > -   !virtqueue_is_broken(vi->cvq)) > > > > +   !virtqueue_is_broken(vi->cvq)) { > > > > +    if (timeout) > > > > +    timeout--; > > > This is not really a timeout, just a loop counter. 200 iterations cou

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Heng Qi
在 2024/1/18 下午8:01, Zhu Yanjun 写道: 在 2024/1/16 20:04, Paolo Abeni 写道: On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: From: Zhu Yanjun Some devices emulate the virtio_net hardwares. When virtio_net driver sends commands to the emulated hardware, normally the hardware needs time to re

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-18 Thread Xuan Zhuo
On Thu, 18 Jan 2024 08:14:21 -0500, "Michael S. Tsirkin" wrote: > On Tue, Jan 16, 2024 at 01:04:49PM +0100, Paolo Abeni wrote: > > On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: > > > From: Zhu Yanjun > > > > > > Some devices emulate the virtio_net hardwares. When virtio_net > > > driver s

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-18 Thread Michael S. Tsirkin
On Tue, Jan 16, 2024 at 01:04:49PM +0100, Paolo Abeni wrote: > On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: > > From: Zhu Yanjun > > > > Some devices emulate the virtio_net hardwares. When virtio_net > > driver sends commands to the emulated hardware, normally the > > hardware needs time

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-18 Thread Zhu Yanjun
在 2024/1/16 20:04, Paolo Abeni 写道: On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: From: Zhu Yanjun Some devices emulate the virtio_net hardwares. When virtio_net driver sends commands to the emulated hardware, normally the hardware needs time to response. Sometimes the time is very lon

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-16 Thread Paolo Abeni
On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: > From: Zhu Yanjun > > Some devices emulate the virtio_net hardwares. When virtio_net > driver sends commands to the emulated hardware, normally the > hardware needs time to response. Sometimes the time is very > long. Thus, the following will

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-15 Thread Zhu Yanjun
在 2024/1/15 10:20, Jason Wang 写道: On Mon, Jan 15, 2024 at 9:35 AM Zhu Yanjun wrote: From: Zhu Yanjun Some devices emulate the virtio_net hardwares. When virtio_net driver sends commands to the emulated hardware, normally the hardware needs time to response. Sometimes the time is very long.

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-14 Thread Jason Wang
On Mon, Jan 15, 2024 at 9:35 AM Zhu Yanjun wrote: > > From: Zhu Yanjun > > Some devices emulate the virtio_net hardwares. When virtio_net > driver sends commands to the emulated hardware, normally the > hardware needs time to response. Sometimes the time is very > long. Thus, the following will a