Re: [PATCH 01/12] Make and configuration files.

2016-12-28 Thread Joe Perches
On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote: > Patches to create the make and configuration file [] > \ No newline at end of file Not good > diff --git a/drivers/net/ethernet/aquantia/atlantic/Makefile > b/drivers/net/ethernet/aquantia/atlantic/Makefile A really atypical Makefile y

Re: [PATCH 01/12] Make and configuration files.

2016-12-27 Thread David VomLehn
On 12/27/2016 08:47 PM, Rami Rosen wrote: Hi, David, For the Makefile, you should follow the pattern which is common in Linux Kernel Ethernet drivers, for example, http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/i40e/Makefile or http://lxr.free-electrons.com/source/drivers/net/et

Re: [PATCH 01/12] Make and configuration files.

2016-12-27 Thread Rami Rosen
Hi, David, For the Makefile, you should follow the pattern which is common in Linux Kernel Ethernet drivers, for example, http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/i40e/Makefile or http://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx5/core/Makefile Don't t

Re: [PATCH 01/12] Make and configuration files.

2016-12-27 Thread Joe Perches
On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote: > Patches to create the make and configuration files. A few small things about this patch series that adds a new driver: These should be sent with a cover letter [0/N] so that the reason this series is useful can be added to the merge log.