Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Patrick McHardy írta: Laszlo Attila Toth wrote: The only reason why it can't be set to zero again seems to be this part from the iproute patch: +if (rtnl_ifgroup_a2n(&group, *argv) || group == 0) Why don't you allow a value of zero? It has historical

Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: Hello, Here is the new version of ifgroup patches. The interface group value is u_int32_t in net_device which should be enough. Previously it was an int. Usage: ip link set eth0 group 4 but currently it cannot be unset, only changed to anot

Re: [PATCH 0/2] Interface groups, round two

2007-10-18 Thread Patrick McHardy
Laszlo Attila Toth wrote: Hello, Here is the new version of ifgroup patches. The interface group value is u_int32_t in net_device which should be enough. Previously it was an int. Usage: ip link set eth0 group 4 but currently it cannot be unset, only changed to another value. The only re

Re: [PATCH 0/2] Interface groups

2007-10-16 Thread Laszlo Attila Toth
Philip Craig írta: Laszlo Attila Toth wrote: Hello, Different network interfaces can be grouped using the same group ID. With this patch fewer netfilter rules are necessary but it may also be used by routing. This allows an interface to belong to only one group. I expect there are situations

Re: [PATCH 0/2] Interface groups

2007-10-16 Thread Philip Craig
Laszlo Attila Toth wrote: > Hello, > > Different network interfaces can be grouped using the same group ID. With this > patch fewer netfilter rules are necessary but it may also be used by routing. This allows an interface to belong to only one group. I expect there are situations where you want