Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-14 Thread Jeremy Fitzhardinge
Jesper Juhl wrote: > This moves the updating of both tx_bytes and tx_packets inside the > spinlock, but as far as I can see we only _really_ need to move the > tx_bytes update. Considering that we generally want to do as little > work as possible while holding a lock, wouldn't the following be

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. Jeff, this is -rc material. Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> applied - To unsubscrib

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jesper Juhl
On Monday 13 August 2007 21:54:37 Jeremy Fitzhardinge wrote: > xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. > > Jeff, this is -rc material. > > Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> > Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> > Cc: Jeff Garzik <