Re: [PATCH] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-22 Thread Jakub Kicinski
On Tue, 22 Dec 2020 11:49:04 +0800 Jason Wang wrote: > On 2020/12/22 上午11:36, Jeff Dike wrote: > > virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS > > and CONFIG_HOTPLUG are enabled. > > > > The path is: > > virtnet_set_channels - calls get_online_cpus(), which is a triv

Re: [PATCH] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-22 Thread Michael S. Tsirkin
On Mon, Dec 21, 2020 at 10:36:48PM -0500, Jeff Dike wrote: > virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS > and CONFIG_HOTPLUG are enabled. > > The path is: > virtnet_set_channels - calls get_online_cpus(), which is a trivial > wrapper around cpus_read_lock() > ne

Re: [PATCH] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-21 Thread Jason Wang
On 2020/12/22 上午11:36, Jeff Dike wrote: virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS and CONFIG_HOTPLUG are enabled. The path is: virtnet_set_channels - calls get_online_cpus(), which is a trivial wrapper around cpus_read_lock() netif_set_real_num_tx_queues