Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-25 Thread Jeff Garzik
The patch went upstream ~24 hours ago: c43c49bd61fdb9bb085ddafcaadb17d06f95ec43 Upstream is the base for any new patches. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.o

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-25 Thread Dan Williams
On Wed, 2007-04-25 at 18:09 +0300, Petko Manolov wrote: > On Wed, 25 Apr 2007, Dan Williams wrote: > > > On Wed, 2007-04-25 at 17:58 +0300, Petko Manolov wrote: > >> In general i agree with the reasoning below. However, isn't it better to > >> remove the code that sets carrier on/off in intr_call

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-25 Thread Petko Manolov
On Wed, 25 Apr 2007, Dan Williams wrote: On Wed, 2007-04-25 at 17:58 +0300, Petko Manolov wrote: In general i agree with the reasoning below. However, isn't it better to remove the code that sets carrier on/off in intr_callback()? I'm fine with this; whatever makes carrier status work makes

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-25 Thread Dan Williams
On Wed, 2007-04-25 at 17:58 +0300, Petko Manolov wrote: > In general i agree with the reasoning below. However, isn't it better to > remove the code that sets carrier on/off in intr_callback()? I'm fine with this; whatever makes carrier status work makes me happy :) Dan > There's a reliable wa

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-25 Thread Petko Manolov
In general i agree with the reasoning below. However, isn't it better to remove the code that sets carrier on/off in intr_callback()? There's a reliable way of getting the link status by reading the MII. After correct checking of the return value from read_mii_word(), set_carrier() is what is

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-24 Thread Dan Williams
On Tue, 2007-04-24 at 20:48 +0300, [EMAIL PROTECTED] wrote: > > On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote: > >> Long term, Greg seemed OK with moving the net drivers from > >> drivers/usb/net > >> to drivers/usb/net, in line with the current policy of placing net > >> drivers >

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-24 Thread petkan
> On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote: >> Long term, Greg seemed OK with moving the net drivers from >> drivers/usb/net >> to drivers/usb/net, in line with the current policy of placing net >> drivers >> in drivers/net/*, bus agnostic. After that move, sending to netdev

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-24 Thread Jeff Garzik
Greg KH wrote: On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote: Long term, Greg seemed OK with moving the net drivers from drivers/usb/net to drivers/usb/net, in line with the current policy of placing net drivers in drivers/net/*, bus agnostic. After that move, sending to netde

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-24 Thread Greg KH
On Tue, Apr 24, 2007 at 12:49:12PM -0400, Jeff Garzik wrote: > Long term, Greg seemed OK with moving the net drivers from drivers/usb/net > to drivers/usb/net, in line with the current policy of placing net drivers > in drivers/net/*, bus agnostic. After that move, sending to netdev and me >

Re: [PATCH] usb-net/pegasus: fix pegasus carrier detection

2007-04-24 Thread Jeff Garzik
Dan Williams wrote: Broken by 4a1728a28a193aa388900714bbb1f375e08a6d8e which switched the return semantics of read_mii_word() but didn't fix usage of read_mii_word() to conform to the new semantics. Setting carrier to off based on the NO_CARRIER flag is also incorrect as that flag only triggers