Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-26 Thread Dan Carpenter
Hi Ricardo, url: https://github.com/0day-ci/linux/commits/Ricardo-Dias/tcp-fix-race-condition-when-creating-child-sockets-from-syncookies/20201023-191433 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 105faa8742437c28815b2a3eb8314ebc5fd9288c config: i386-randconfig

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-23 Thread Ricardo Dias
On Fri, Oct 23, 2020 at 06:51:05PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 6:48 PM Ricardo Dias wrote: > > > > > In that case, I can change the patch to only iterate the ehash bucket > > only when the listening socket is using the loopback interface, correct? > > No, the fix should

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-23 Thread Ricardo Dias
On Fri, Oct 23, 2020 at 06:36:29PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 6:06 PM Ricardo Dias wrote: > > > And what about the loopback interface? Why couldn't the loopback > > interface also use a single RX queue? > > > > Loopback is using a per-cpu queue, with no crossing, for ef

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-23 Thread Ricardo Dias
On Fri, Oct 23, 2020 at 05:56:07PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 5:51 PM Ricardo Dias wrote: > > > > On Fri, Oct 23, 2020 at 04:03:27PM +0200, Eric Dumazet wrote: > > > On Fri, Oct 23, 2020 at 1:14 PM Ricardo Dias wrote: > > > > > > ... > > > > > > Note that normally, all p

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-23 Thread Ricardo Dias
On Fri, Oct 23, 2020 at 04:03:27PM +0200, Eric Dumazet wrote: > On Fri, Oct 23, 2020 at 1:14 PM Ricardo Dias wrote: > > > > When the TCP stack is in SYN flood mode, the server child socket is > > created from the SYN cookie received in a TCP packet with the ACK flag > > set. > > > ... > > This pa

Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies

2020-10-23 Thread kernel test robot
Hi Ricardo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on net/master linus/master v5.9 next-20201023] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to