Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-29 Thread Heiner Kallweit
On 29.01.2019 18:40, Thierry Reding wrote: > On Fri, Jan 25, 2019 at 07:34:31PM +0100, Heiner Kallweit wrote: >> On 25.01.2019 11:18, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> If the system was booted using a device tree and if the device tree >>> contains a MAC address, use it instea

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-29 Thread Thierry Reding
On Fri, Jan 25, 2019 at 07:34:31PM +0100, Heiner Kallweit wrote: > On 25.01.2019 11:18, Thierry Reding wrote: > > From: Thierry Reding > > > > If the system was booted using a device tree and if the device tree > > contains a MAC address, use it instead of reading one from the EEPROM. > > This is

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Heiner Kallweit
On 25.01.2019 20:07, Andrew Lunn wrote: >> Andrew, for my understanding: What do you think is wrong with the >> alignment requirement? It was introduced because we do a 32 bit access >> to the start address of the array and want to avoid an unaligned access. > > Hi Heiner > > Because you are doi

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Andrew Lunn
> Andrew, for my understanding: What do you think is wrong with the > alignment requirement? It was introduced because we do a 32 bit access > to the start address of the array and want to avoid an unaligned access. Hi Heiner Because you are doing pointer aliasing, the compiler will by default g

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Heiner Kallweit
On 25.01.2019 11:18, Thierry Reding wrote: > From: Thierry Reding > > If the system was booted using a device tree and if the device tree > contains a MAC address, use it instead of reading one from the EEPROM. > This is useful in situations where the EEPROM isn't properly programmed > or where t

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Heiner Kallweit
On 25.01.2019 15:57, Andrew Lunn wrote: > On Fri, Jan 25, 2019 at 11:18:14AM +0100, Thierry Reding wrote: >> From: Thierry Reding >> >> If the system was booted using a device tree and if the device tree >> contains a MAC address, use it instead of reading one from the EEPROM. >> This is useful in

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Thierry Reding
On Fri, Jan 25, 2019 at 03:57:11PM +0100, Andrew Lunn wrote: > On Fri, Jan 25, 2019 at 11:18:14AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > If the system was booted using a device tree and if the device tree > > contains a MAC address, use it instead of reading one from the EE

Re: [PATCH] r8169: Load MAC address from device tree if present

2019-01-25 Thread Andrew Lunn
On Fri, Jan 25, 2019 at 11:18:14AM +0100, Thierry Reding wrote: > From: Thierry Reding > > If the system was booted using a device tree and if the device tree > contains a MAC address, use it instead of reading one from the EEPROM. > This is useful in situations where the EEPROM isn't properly pr