Re: [PATCH] pcnet32.c: modify RX ring size through module parameter

2006-05-15 Thread Wen Hsin Chang
There are cases where rx errors were found due to rx ring size being too small during remote installation using pcnet32. It is found that ethtool functionality may not be available under such circumenstance. This is the purpose behind this patch. However, as Don pointed out, there are several p

Re: [PATCH] pcnet32.c: modify RX ring size through module parameter

2006-05-15 Thread Jon Mason
Why is this necessary? There is already an ethtool function to set the rx ring size (pcnet32_set_ringparam). Since module parameters are being phased out in favor of the ethtool functions, why not use the existing ethtool infrastructure for this? Thanks, Jon On Mon, May 15, 2006 at 11:32:14AM +

Re: [PATCH] pcnet32.c: modify RX ring size through module parameter

2006-05-15 Thread Don Fry
I have several problems with this patch. First, it assumes you only have one device or you want all devices to operate with the same receive ring size. (use module_param_array like full_duplex or options). Second, the mininum number of descriptors should be 4 not 2, or the loopback test will loo