Re: [PATCH] openvswitch: Allow attaching helper in later commit

2019-10-03 Thread Yi-Hung Wei
On Thu, Oct 3, 2019 at 8:31 AM David Miller wrote: > > From: Yi-Hung Wei > Date: Mon, 30 Sep 2019 12:39:04 -0700 > > > - if ((nf_ct_is_confirmed(ct) ? !cached : info->commit) && > > + if ((nf_ct_is_confirmed(ct) ? !cached | add_helper : > > I would suggest using "||" inste

Re: [PATCH] openvswitch: Allow attaching helper in later commit

2019-10-03 Thread David Miller
From: Yi-Hung Wei Date: Mon, 30 Sep 2019 12:39:04 -0700 > - if ((nf_ct_is_confirmed(ct) ? !cached : info->commit) && > + if ((nf_ct_is_confirmed(ct) ? !cached | add_helper : I would suggest using "||" instea of "|" here since you are computing a boolean.