Re: [PATCH] openvswitch: Add packet truncation support.

2016-06-09 Thread pravin shelar
On Thu, Jun 9, 2016 at 1:02 PM, William Tu wrote: > >> > >> > /* The only known usage of sample action is having a single >> > user-space >> > +* action, or having a truncate action followed by a single >> > user-space >> > * action. Treat this usage as a special case. >>

Re: [PATCH] openvswitch: Add packet truncation support.

2016-06-09 Thread pravin shelar
On Thu, Jun 9, 2016 at 8:57 AM, Rick Jones wrote: > On 06/08/2016 09:30 PM, pravin shelar wrote: >> >> On Wed, Jun 8, 2016 at 6:18 PM, William Tu wrote: >>> >>> +struct ovs_action_trunc { >>> + uint32_t max_len; /* Max packet size in bytes. */ >> >> This could uint16_t. as it is related to

Re: [PATCH] openvswitch: Add packet truncation support.

2016-06-09 Thread Rick Jones
On 06/08/2016 09:30 PM, pravin shelar wrote: On Wed, Jun 8, 2016 at 6:18 PM, William Tu wrote: +struct ovs_action_trunc { + uint32_t max_len; /* Max packet size in bytes. */ This could uint16_t. as it is related to packet len. Is there something limiting MTUs to 65535 bytes? rick jon

Re: [PATCH] openvswitch: Add packet truncation support.

2016-06-08 Thread pravin shelar
On Wed, Jun 8, 2016 at 6:18 PM, William Tu wrote: > The patch adds a new OVS action, OVS_ACTION_ATTR_TRUNC, in order to > truncate packets. A 'max_len' is added for setting up the maximum > packet size, and a 'cutlen' field is to record the number of bytes > to trim the packet when the packet is o