Hi,
On Mon, 19 Sep 2016 13:46:10 -0700 pravin shelar wrote:
> On Mon, Sep 19, 2016 at 1:04 PM, Shmulik Ladkani
> wrote:
> > Hi Pravin,
> >
> > On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote:
> >> > +++ b/net/core/skbuff.c
> >> > @@ -4537,7 +4537,7 @@ int skb_vlan_pop(struct sk_buff *s
On Mon, Sep 19, 2016 at 1:04 PM, Shmulik Ladkani
wrote:
> Hi Pravin,
>
> On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote:
>> > +++ b/net/core/skbuff.c
>> > @@ -4537,7 +4537,7 @@ int skb_vlan_pop(struct sk_buff *skb)
>> > } else {
>> > if (unlikely((skb->protocol !=
Hi Pravin,
On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote:
> > +++ b/net/core/skbuff.c
> > @@ -4537,7 +4537,7 @@ int skb_vlan_pop(struct sk_buff *skb)
> > } else {
> > if (unlikely((skb->protocol != htons(ETH_P_8021Q) &&
> > skb->proto
On Mon, 19 Sep 2016 16:05:17 +0300 Shmulik Ladkani
wrote:
> Also, I'm okay with removing the excess 'skb->mac_len < VLAN_ETH_HLEN'
> condition if it is agreed that the "tag exists but insufficient to pop"
> semantic is no longer wanted.
Thinking this over, the condition is indeed superflous, wil
On Mon, 19 Sep 2016 14:22:57 +0200, dan...@iogearbox.net wrote:
> On 09/19/2016 08:15 AM, Shmulik Ladkani wrote:
> > On Sun, 18 Sep 2016 13:26:30 -0700, pshe...@ovn.org wrote:
> >> On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani
> >> wrote:
> >>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
On 09/19/2016 08:15 AM, Shmulik Ladkani wrote:
On Sun, 18 Sep 2016 13:26:30 -0700, pshe...@ovn.org wrote:
On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani
wrote:
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 1e329d4112..cc2c004838 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff
Hi,
On Sun, 18 Sep 2016 13:26:30 -0700, pshe...@ovn.org wrote:
> On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani
> wrote:
> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > index 1e329d4112..cc2c004838 100644
> > --- a/net/core/skbuff.c
> > +++ b/net/core/skbuff.c
> > @@ -4537,7 +4537,7
On Sun, Sep 18, 2016 at 3:09 AM, Shmulik Ladkani
wrote:
> In 93515d53b1
> "net: move vlan pop/push functions into common code"
> skb_vlan_pop was moved from its private location in openvswitch to
> skbuff common code.
>
> In case !vlan_tx_tag_present, the original 'pop_vlan()' assured
> that skb
