Re: [PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-29 Thread Charles Keepax
On Mon, Mar 28, 2016 at 08:30:11PM +0300, Sergei Shtylyov wrote: > >@@ -3029,7 +3030,8 @@ static int macb_remove(struct platform_device *pdev) > > mdiobus_free(bp->mii_bus); > > > > /* Shutdown the PHY if there is a GPIO reset */ > >-gpiod_set_value(bp->reset_gpi

Re: [PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-28 Thread Sergei Shtylyov
Hello. On 03/28/2016 03:47 PM, Charles Keepax wrote: GPIOlib will print warning messages if we call GPIO functions without a valid GPIO. Change the code to avoid doing so. Signed-off-by: Charles Keepax --- drivers/net/ethernet/cadence/macb.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-28 Thread David Miller
From: Charles Keepax Date: Mon, 28 Mar 2016 13:47:42 +0100 > GPIOlib will print warning messages if we call GPIO functions without a > valid GPIO. Change the code to avoid doing so. > > Signed-off-by: Charles Keepax Applied.