> > Well, until the user of this new API is ready, we will not accept the
> > patch.
> OK, but once we submit the change in the driver, is it good to go?
No. You really do need to explain why it is needed, and why it is
safe.
> > You also need to explain "For HW performance reasons". Why is this
My comments inline.
Thanks,
Ilia Lin
On Tue, Aug 4, 2020 at 10:24 PM Andrew Lunn wrote:
>
> On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote:
> > Hi Andrew and David,
>
> Hi Ilia
>
> Please don't top post.
>
> >
> > Thank you for your comments!
> >
> > The client driver is still work in
On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote:
> Hi Andrew and David,
Hi Ilia
Please don't top post.
>
> Thank you for your comments!
>
> The client driver is still work in progress, but it can be seen here:
> https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platfo
Hi Andrew and David,
Thank you for your comments!
The client driver is still work in progress, but it can be seen here:
https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842
For HW performance reasons, it has to be in subsys_initcall.
Here is the re
Hi Andrew and David,
Thank you for your comments!
The client driver is still work in progress, but it can be seen here:
https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842
For HW performance reasons, it has to be in subsys_initcall.
Here is the re
From: Andrew Lunn
Date: Sun, 26 Jul 2020 21:45:28 +0200
> I also have to wonder why a network device driver is being probed the
> subsys_initcall.
This makes me wonder how this interface could even be useful. The
only way to fix the problem is to change when the device is probed,
which would me
On Sun, Jul 26, 2020 at 10:37:54PM +0300, Ilia Lin wrote:
> From: Ilia Lin
>
> Add an API that returns true, if the net_dev_init was already called,
> and the driver was initialized.
>
> Some early drivers, that are initialized during the subsys_initcall
> may try accessing the net_dev or NAPI A
