Re: [PATCH] net: cx89x0: move attribute declaration before struct keyword

2017-04-17 Thread David Miller
From: Stefan Agner Date: Mon, 17 Apr 2017 13:31:28 -0700 > Given that, can you reconsider? Please put the attribute after the compete type. Thanks.

Re: [PATCH] net: cx89x0: move attribute declaration before struct keyword

2017-04-17 Thread Stefan Agner
On 2017-04-17 13:09, David Miller wrote: > From: Stefan Agner > Date: Sun, 16 Apr 2017 23:20:32 -0700 > >> The attribute declaration is typically before the definition. Move >> the __maybe_unused attribute declaration before the struct keyword. >> >> Signed-off-by: Stefan Agner > I did catch t

Re: [PATCH] net: cx89x0: move attribute declaration before struct keyword

2017-04-17 Thread David Miller
From: Stefan Agner Date: Sun, 16 Apr 2017 23:20:32 -0700 > The attribute declaration is typically before the definition. Move > the __maybe_unused attribute declaration before the struct keyword. > > Signed-off-by: Stefan Agner Well, I see if just as often after the variable name too: net/ird