Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 19:26, Stephen Hemminger wrote: > On Mon, 22 Jan 2018 12:41:41 +0300 > Kirill Tkhai wrote: > >> Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing >> synchronize_net() says: >> >> >When we hold RTNL mutex, we would like to spend some cpu cycles but not >>

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 20:34, Eric Dumazet wrote: > On Tue, 2018-01-23 at 20:22 +0300, Kirill Tkhai wrote: >> >> Eric, I took your advice about net-next from your the first message and >> agreed in my answer on it. Strange, you've repeated this already 3 times >> though I have no objections. > > That was a

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
On Tue, 2018-01-23 at 20:22 +0300, Kirill Tkhai wrote: > > Eric, I took your advice about net-next from your the first message and > agreed in my answer on it. Strange, you've repeated this already 3 times > though I have no objections. That was absolutely not clear to me. Sorry for this. Next

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 20:13, Eric Dumazet wrote: > On Tue, Jan 23, 2018 at 9:09 AM, Kirill Tkhai wrote: >> On 23.01.2018 19:58, Eric Dumazet wrote: Your original patch did not provide any test results. Only the fact synchronize_rcu_expedited() completes faster than plain synchronize_r

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
On Tue, Jan 23, 2018 at 9:09 AM, Kirill Tkhai wrote: > On 23.01.2018 19:58, Eric Dumazet wrote: >>> >>> Your original patch did not provide any test results. Only the fact >>> synchronize_rcu_expedited() >>> completes faster than plain synchronize_rcu(). But this is an obvious fact >>> just becau

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 19:58, Eric Dumazet wrote: >> >> Your original patch did not provide any test results. Only the fact >> synchronize_rcu_expedited() >> completes faster than plain synchronize_rcu(). But this is an obvious fact >> just because of the design, and this is described even in the documenta

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
> > Your original patch did not provide any test results. Only the fact > synchronize_rcu_expedited() > completes faster than plain synchronize_rcu(). But this is an obvious fact > just because of the design, and this is described even in the documentation. > Beleive me, I don't want to offend you

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 19:26, Stephen Hemminger wrote: > On Mon, 22 Jan 2018 12:41:41 +0300 > Kirill Tkhai wrote: > >> Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing >> synchronize_net() says: >> >> >When we hold RTNL mutex, we would like to spend some cpu cycles but not >>

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 19:05, Eric Dumazet wrote: > On Tue, Jan 23, 2018 at 7:57 AM, Kirill Tkhai wrote: >> On 23.01.2018 18:45, Eric Dumazet wrote: >>> On Tue, Jan 23, 2018 at 7:29 AM, Kirill Tkhai wrote: On 23.01.2018 18:12, Eric Dumazet wrote: > On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Stephen Hemminger
On Mon, 22 Jan 2018 12:41:41 +0300 Kirill Tkhai wrote: > Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing > synchronize_net() says: > > >When we hold RTNL mutex, we would like to spend some cpu cycles but not > >block too long other processes waiting for this mutex.

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
On Tue, Jan 23, 2018 at 7:57 AM, Kirill Tkhai wrote: > On 23.01.2018 18:45, Eric Dumazet wrote: >> On Tue, Jan 23, 2018 at 7:29 AM, Kirill Tkhai wrote: >>> On 23.01.2018 18:12, Eric Dumazet wrote: On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai wrote: > Hi, Eric, > > thanks for yo

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 18:45, Eric Dumazet wrote: > On Tue, Jan 23, 2018 at 7:29 AM, Kirill Tkhai wrote: >> On 23.01.2018 18:12, Eric Dumazet wrote: >>> On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai wrote: Hi, Eric, thanks for your review. On 22.01.2018 20:15, Eric Dumazet wrote:

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
On Tue, Jan 23, 2018 at 7:29 AM, Kirill Tkhai wrote: > On 23.01.2018 18:12, Eric Dumazet wrote: >> On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai wrote: >>> Hi, Eric, >>> >>> thanks for your review. >>> >>> On 22.01.2018 20:15, Eric Dumazet wrote: On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkh

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
On 23.01.2018 18:12, Eric Dumazet wrote: > On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai wrote: >> Hi, Eric, >> >> thanks for your review. >> >> On 22.01.2018 20:15, Eric Dumazet wrote: >>> On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkhai wrote: Commit be3fc413da9e "net: use synchronize_rcu_ex

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Eric Dumazet
On Tue, Jan 23, 2018 at 6:41 AM, Kirill Tkhai wrote: > Hi, Eric, > > thanks for your review. > > On 22.01.2018 20:15, Eric Dumazet wrote: >> On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkhai wrote: >>> Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing >>> synchronize_net() says:

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-23 Thread Kirill Tkhai
Hi, Eric, thanks for your review. On 22.01.2018 20:15, Eric Dumazet wrote: > On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkhai wrote: >> Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing >> synchronize_net() says: >> >> >When we hold RTNL mutex, we would like to spend some

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

2018-01-22 Thread Eric Dumazet
On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkhai wrote: > Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing > synchronize_net() says: > > >When we hold RTNL mutex, we would like to spend some cpu cycles but not > >block too long other processes waiting for this mutex. >