Re: [PATCH] net/sock: don't drop udp packets if udp_mem[2] not reached

2020-09-08 Thread dust.li
On Tue, Sep 08, 2020 at 10:46:13AM +0200, Paolo Abeni wrote: >Hi, > >On Tue, 2020-09-08 at 11:15 +0800, dust.li wrote: >> Actually, with more udp sockets, I can always make it large >> enough to exceed udp_mem[0], and drop packets before udp_mem[1] >> and udp_mem[2]. > >Sure, but with enough socket

Re: [PATCH] net/sock: don't drop udp packets if udp_mem[2] not reached

2020-09-08 Thread Paolo Abeni
Hi, On Tue, 2020-09-08 at 11:15 +0800, dust.li wrote: > Actually, with more udp sockets, I can always make it large > enough to exceed udp_mem[0], and drop packets before udp_mem[1] > and udp_mem[2]. Sure, but with enough sockets you can also exceeeds any limits ;). > diff --git a/net/core/sock.

Re: [PATCH] net/sock: don't drop udp packets if udp_mem[2] not reached

2020-09-07 Thread dust.li
On Mon, Sep 07, 2020 at 07:18:48PM +0200, Paolo Abeni wrote: >Hi, > >On Mon, 2020-09-07 at 22:44 +0800, Dust Li wrote: >> We encoutered udp packets drop under a pretty low pressure >> with net.ipv4.udp_mem[0] set to a small value (4096). >> >> After some tracing and debugging, we found that for ud

Re: [PATCH] net/sock: don't drop udp packets if udp_mem[2] not reached

2020-09-07 Thread Paolo Abeni
Hi, On Mon, 2020-09-07 at 22:44 +0800, Dust Li wrote: > We encoutered udp packets drop under a pretty low pressure > with net.ipv4.udp_mem[0] set to a small value (4096). > > After some tracing and debugging, we found that for udp > protocol, __sk_mem_raise_allocated() will possiblly drop > packe