Re: [PATCH] memory leak in netlink user->kernel processing

2007-10-01 Thread Eric W. Biederman
Patrick McHardy <[EMAIL PROTECTED]> writes: > Denis V. Lunev wrote: >> By the way, Patrick, this looks like nlk->pid == 0 if and only if this >> is a kernel socket. Right? >> > > Thats correct. > >> I have told with Alexey Kuznetsov and we have discrovered a way to get >> rid of >> skb_que

Re: [PATCH] memory leak in netlink user->kernel processing

2007-10-01 Thread Patrick McHardy
Denis V. Lunev wrote: By the way, Patrick, this looks like nlk->pid == 0 if and only if this is a kernel socket. Right? Thats correct. I have told with Alexey Kuznetsov and we have discrovered a way to get rid of skb_queue_tail(&sk->sk_receive_queue, skb); sk->sk_data_ready

Re: [PATCH] memory leak in netlink user->kernel processing

2007-10-01 Thread Denis V. Lunev
Patrick McHardy wrote: > Denis V. Lunev wrote: >> netlink_kernel_create can be called with NULL as an input callback in several >> places, f.e. in kobject_uevent_init. This means that if one sends packet from >> user to kernel for such a socket, the packet will be leaked in the socket >> queue fore

Re: [PATCH] memory leak in netlink user->kernel processing

2007-10-01 Thread Patrick McHardy
Denis V. Lunev wrote: > netlink_kernel_create can be called with NULL as an input callback in several > places, f.e. in kobject_uevent_init. This means that if one sends packet from > user to kernel for such a socket, the packet will be leaked in the socket > queue forever. > > This patch adds a s