From: Tom Herbert
Date: Mon, 13 Jul 2015 08:31:05 -0700
> I am testing this patch which may be a little simpler. Also idev needs
> to be checked after __in6_dev_get
Tom, I'm applying Hideaki's fix for now.
If you want to simplify the code, feel free to submit that as a
follow-up, thank you!
--
From: YOSHIFUJI Hideaki/吉藤英明
Date: Mon, 13 Jul 2015 23:28:10 +0900
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best source address available. Plus, it introduced
> possible NULL pointer dereference
And I now have a use_oif_addr sysctl patch that, on top if this one,
passes all my tests.
On 15 July 2015 at 18:15, Erik Kline wrote:
> All my tests pass with this applied to net-next/master.
>
> Many thanks!
>
> Acked-by: Erik Kline
>
> On 13 July 2015 at 23:28, YOSHIFUJI Hideaki/吉藤英明
> wrote:
All my tests pass with this applied to net-next/master.
Many thanks!
Acked-by: Erik Kline
On 13 July 2015 at 23:28, YOSHIFUJI Hideaki/吉藤英明
wrote:
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best
On Tue, Jul 14, 2015 at 5:44 AM, YOSHIFUJI Hideaki/吉藤英明
wrote:
> Hi,
>
> Tom Herbert wrote:
>> I am testing this patch which may be a little simpler. Also idev needs
>> to be checked after __in6_dev_get
>
> We have to select source address on *given* interface for link-local/
> multicast destinati
Hi,
Tom Herbert wrote:
> I am testing this patch which may be a little simpler. Also idev needs
> to be checked after __in6_dev_get
We have to select source address on *given* interface for link-local/
multicast destinations.
>
> Tom
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>
I am testing this patch which may be a little simpler. Also idev needs
to be checked after __in6_dev_get
Tom
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 4ab74d5..d631ac3 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1363,9 +1363,10 @@ static void __ipv6_dev_get_s
At Mon, 13 Jul 2015 23:28:10 +0900,
YOSHIFUJI Hideaki/吉藤英明 wrote:
>
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best source address available. Plus, it introduced
> possible NULL pointer dereferenc
