Re: [PATCH] flex_can: Fix checking can_dlc

2017-12-25 Thread Oliver Hartkopp
Answering myself after reading my own comment once more: In fact the code fix seems to be correct but the commit comment was completely wrong which lead to my answer ... can_dlc can hold values from 0 .. 8. The first 4 bytes are placed in data[0..3]. When we have more(!) than 4 bytes in can_

Re: [PATCH] flex_can: Fix checking can_dlc

2017-12-25 Thread Oliver Hartkopp
This patch looks wrong to me. On 12/19/2017 09:40 AM, Luu An Phu wrote: From: "phu.luuan" flexcan_start_xmit should write data to register when can_dlc > 4. Because can_dlc is data length and it has value from 1 to 8. No. can_dlc can contain values from 0 to 8. Even 0 is a valid DLC. But C