Re: [PATCH] ethtool: fix a kernel infoleak in ethtool_get_pauseparam

2016-06-01 Thread Ben Hutchings
On Wed, 2016-06-01 at 16:39 +0200, Kangjie Lu wrote: > The field autoneg of pauseparam is not initialized in some > implementations of get_pauseparam(), Nonsense.  The current implementation initialises all fields.  (If there was padding in the structure, this change would be needed to guarantee t

Re: [PATCH] ethtool: fix a kernel infoleak in ethtool_get_pauseparam

2016-06-01 Thread Edward Cree
On 01/06/16 15:39, Kangjie Lu wrote: > The field autoneg of pauseparam is not initialized in some > implementations of get_pauseparam(), but the whole object is > copied to userland. > > Signed-off-by: Kangjie Lu > --- > net/core/ethtool.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(