>
> Branch "next" is merged into master now so you can base v2 on master.
>
Hi Michal!
Just submitted v2. I fixed the little problems noticed by Ido and you.
The submission consists of only one patch, since I noticed that some
extra whitespace 'fixes' were wrongly introduced by my editor so I
sup
On Tue, Aug 04, 2020 at 11:25:48AM +0100, Adrian Pop wrote:
> >
> > AFAICS the kernel counterpart is going to reach mainline in 5.9-rc1
> > merge window. Please base your patch on "next" branch or wait until next
> > is merged into master after 5.8 release (which should be later today or
> > tomorr
I noticed one more minor problem:
On Fri, Jul 31, 2020 at 11:47:25AM +0300, Adrian Pop wrote:
> +static void qsfp_dd_show_sig_optical_pwr(const __u8 *id, __u32 eeprom_len)
> +{
> + static const char * const aw_strings[] = {
> + "%s power high alarm (Channel %d)",
> +
>
> AFAICS the kernel counterpart is going to reach mainline in 5.9-rc1
> merge window. Please base your patch on "next" branch or wait until next
> is merged into master after 5.8 release (which should be later today or
> tomorrow).
I will wait until tomorrow and rebase my patch onto master then.
On Fri, Jul 31, 2020 at 11:47:25AM +0300, Adrian Pop wrote:
> The Common Management Interface Specification (CMIS) for QSFP-DD shares
> some similarities with other form factors such as QSFP or SFP, but due to
> the fact that the module memory map is different, the current ethtool
> version is not
Hi Andrew, Ido!
> Hi Adrian, thanks again for submitting this patch. I got two comments
> off-list. Sharing them here.
Thanks for pointing that out, I took a look and you're right. I'll fix them.
> Didn't we discuss that page 3 might be useful? I would prefer not to
> document that pages 0x10 an
Hi Adrian, thanks again for submitting this patch. I got two comments
off-list. Sharing them here.
On Fri, Jul 31, 2020 at 11:47:25AM +0300, Adrian Pop wrote:
> +/**
> + * Print the cable assembly length, for both passive copper and active
> + * optical or electrical cables. The base length (bits
On Fri, Jul 31, 2020 at 11:47:25AM +0300, Adrian Pop wrote:
> The Common Management Interface Specification (CMIS) for QSFP-DD shares
> some similarities with other form factors such as QSFP or SFP, but due to
> the fact that the module memory map is different, the current ethtool
> version is not
