Re: [PATCH] bpf: relax return code check for subprograms

2020-11-12 Thread Dmitrii Banshchikov
On Wed, Nov 11, 2020 at 02:33:11PM -0800, Andrii Nakryiko wrote: > > > > > > > > > switch (prog_type) { > > > > case BPF_PROG_TYPE_CGROUP_SOCK_ADDR: > > > > if (env->prog->expected_attach_type == > > > > BPF_CGROUP_UDP4_RECVMSG || > > > > @@ -7874,7 +7886,6 @@ stat

Re: [PATCH] bpf: relax return code check for subprograms

2020-11-11 Thread Andrii Nakryiko
On Wed, Nov 11, 2020 at 2:38 AM Dmitrii Banshchikov wrote: > > On Tue, Nov 10, 2020 at 08:47:13PM -0800, Andrii Nakryiko wrote: > > On Tue, Nov 10, 2020 at 1:03 PM Dmitrii Banshchikov > > wrote: > > > > > > Currently verifier enforces return code checks for subprograms in the > > > same manner a

Re: [PATCH] bpf: relax return code check for subprograms

2020-11-11 Thread Dmitrii Banshchikov
On Tue, Nov 10, 2020 at 08:47:13PM -0800, Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 1:03 PM Dmitrii Banshchikov > wrote: > > > > Currently verifier enforces return code checks for subprograms in the > > same manner as it does for program entry points. This prevents returning > > arbitrary

Re: [PATCH] bpf: relax return code check for subprograms

2020-11-10 Thread Andrii Nakryiko
On Tue, Nov 10, 2020 at 1:03 PM Dmitrii Banshchikov wrote: > > Currently verifier enforces return code checks for subprograms in the > same manner as it does for program entry points. This prevents returning > arbitrary scalar values from subprograms. Scalar type of returned values > is checked by