Re: [PATCH] bpf: alloc_record_per_cpu Add null check after malloc

2020-06-09 Thread Jesper Dangaard Brouer
On Tue, 9 Jun 2020 08:08:03 -0400 Gaurav Singh wrote: > The memset call is made right after malloc call. To fix this, add the null > check right after malloc and then do memset. > Did you read the section about how long lines should be in desc? > Signed-off-by: Gaurav Singh > --- > sample

Re: [PATCH] bpf: alloc_record_per_cpu Add null check after malloc

2020-06-09 Thread Greg KH
On Tue, Jun 09, 2020 at 07:38:39AM -0400, Gaurav Singh wrote: > Signed-off-by: Gaurav Singh > --- > samples/bpf/xdp_rxq_info_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I know I don't take patches without any changelog text, maybe other maintainers are more lax...

Re: [PATCH] bpf: alloc_record_per_cpu Add null check after malloc

2020-06-08 Thread Jesper Dangaard Brouer
On Sat, 6 Jun 2020 19:59:48 -0400 gaurav singh wrote: > Hi, > > The memset call is made right after malloc call. To fix this, add the null > check right after malloc and then do memset. > > Please find the patch below. The fix in your patch seem correct (although there are more places), but th