Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-22 Thread Yejune Deng
Thank you for the clarification. On Tue, Feb 23, 2021 at 12:07 AM David Ahern wrote: > > On 2/22/21 1:37 AM, Eric Dumazet wrote: > > > > > > On 2/22/21 4:15 AM, Yejune Deng wrote: > >> The arp_hh_ops structure is similar to the arp_generic_ops structure. > >> but the latter is more general,so rem

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-22 Thread David Ahern
On 2/22/21 1:37 AM, Eric Dumazet wrote: > > > On 2/22/21 4:15 AM, Yejune Deng wrote: >> The arp_hh_ops structure is similar to the arp_generic_ops structure. >> but the latter is more general,so remove the arp_hh_ops structure. >> >> Fix when took out the neigh->ops assignment: >> 8.973653] #PF:

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-22 Thread Eric Dumazet
On 2/22/21 4:15 AM, Yejune Deng wrote: > The arp_hh_ops structure is similar to the arp_generic_ops structure. > but the latter is more general,so remove the arp_hh_ops structure. > > Fix when took out the neigh->ops assignment: > 8.973653] #PF: supervisor read access in kernel mode > [8.97

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-20 Thread Yejune Deng
Sorry,it was my fault, I will resubmit. On Sun, Feb 21, 2021 at 9:54 AM David Ahern wrote: > > On 2/19/21 9:32 PM, Yejune Deng wrote: > > static const struct neigh_ops arp_direct_ops = { > > .family = AF_INET, > > .output = neigh_direct_output, > > @@ -277

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-20 Thread David Ahern
On 2/19/21 9:32 PM, Yejune Deng wrote: > static const struct neigh_ops arp_direct_ops = { > .family = AF_INET, > .output = neigh_direct_output, > @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh) > memcpy(neigh->