Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-07 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Mon, 07 Aug 2006 04:45:13 -0400 > I used tcb->end_seq instead of tcb->seq. And add a new condition 'tcb- > seq == tcb->end_seq' to make ACK segment to be counted. ... > Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscr

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-07 Thread Wei Yongjun
I used tcb->end_seq instead of tcb->seq. And add a new condition 'tcb- seq == tcb->end_seq' to make ACK segment to be counted. On Sunday 06 August 2006 22:48, Herbert Xu wrote: > On Sun, Aug 06, 2006 at 07:44:47PM -0700, David Miller wrote: > > From: Herbert Xu <[EMAIL PROTECTED]> > > Date: Mon, 0

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-06 Thread Herbert Xu
On Sun, Aug 06, 2006 at 07:44:47PM -0700, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Mon, 07 Aug 2006 12:40:34 +1000 > > > The general approach looks sound. I have one esoteric question > > though. If a retransmitted packet is coalesced with one that is > > yet to be tran

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 07 Aug 2006 12:40:34 +1000 > The general approach looks sound. I have one esoteric question > though. If a retransmitted packet is coalesced with one that is > yet to be transmitted (a fairly unlikely scenario, but possible I > think), should it co

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-06 Thread Herbert Xu
Wei Yongjun <[EMAIL PROTECTED]> wrote: > > --- a/net/ipv4/tcp_output.c 2006-08-03 18:05:22.425081936 -0400 > +++ b/net/ipv4/tcp_output.c 2006-08-07 09:48:41.186372896 -0400 > @@ -462,7 +462,8 @@ static int tcp_transmit_skb(struct sock >if (skb->len != tcp_header_size) >

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-06 Thread Wei Yongjun
Patch has been fixed. On Friday 04 August 2006 07:23, David Miller wrote: > From: Wei Yongjun <[EMAIL PROTECTED]> > Date: Fri, 04 Aug 2006 08:46:13 -0400 > > > This always correct except when do active open in tcp client, which will > > send a SYN, that segment will not be counted, even if it is n

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-04 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Fri, 04 Aug 2006 08:46:13 -0400 > This always correct except when do active open in tcp client, which will > send a SYN, that segment will not be counted, even if it is not > restrained. Maybe I can do following to fix this: > > int tcp_connect(struct s

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-04 Thread Wei Yongjun
This always correct except when do active open in tcp client, which will send a SYN, that segment will not be counted, even if it is not restrained. Maybe I can do following to fix this: int tcp_connect(struct sock *sk) ... + tp->snd_nxt = tp->write_seq; TCP_SKB_CB(buff)->seq = tp->w

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-03 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Thu, 03 Aug 2006 11:46:58 -0400 > I modified my patch by add a flag to sacked when retransmit, and it > work well. This is the most timing critical code path of the TCP stack output packet processing, and you're adding a read-modify-write operation just

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-08-03 Thread Wei Yongjun
I modified my patch by add a flag to sacked when retransmit, and it work well. On Monday 24 July 2006 17:44, David Miller wrote: > From: Wei Yongjun <[EMAIL PROTECTED]> > Date: Thu, 06 Jul 2006 04:01:18 -0400 > > This test is not accurate enough. For example, timer based > retransmits will not s

Re: [PATCH] SNMPv2 tcpOutSegs counter error

2006-07-24 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Thu, 06 Jul 2006 04:01:18 -0400 > - TCP_INC_STATS(TCP_MIB_OUTSEGS); > + if (!(tcb->sacked & TCPCB_LOST)) > + TCP_INC_STATS(TCP_MIB_OUTSEGS); This test is not accurate enough. For example, timer based retransmits will not set the TCP