Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 04:53:31AM +, Steven J. Hill wrote: > Add main 642xx support to 'drivers/net/mv643xx_eth.c' file. As Christoph said, this quantity of ifdefs really hurt the maintainability. Refactoring is needed. Also, since in arch/powerpc we want to have a single kernel support bot

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

2007-07-19 Thread Christoph Hellwig
On Wed, Jul 18, 2007 at 11:53:31PM -0500, Steven J. Hill wrote: > Add main 642xx support to 'drivers/net/mv643xx_eth.c' file. This is a little too much ifdef mess. Please factor per-controller type code into helper functions, and if they're too much have separate files for either type. - To unsub