Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:54:56 +0200 > Florian Fainelli wrote: > >> Besides missing a declaration and not linking without the network > >> LED config option, its pretty ridiculous to call this for every > >> packet just to make a led blink. > >> > >

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Richard Purdie wrote: On Wed, 2007-07-18 at 15:54 +0200, Patrick McHardy wrote: Florian Fainelli wrote: Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call this for every packet just to make a led blink. Could

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Richard Purdie
On Wed, 2007-07-18 at 15:54 +0200, Patrick McHardy wrote: > Florian Fainelli wrote: > >> Besides missing a declaration and not linking without the network > >> LED config option, its pretty ridiculous to call this for every > >> packet just to make a led blink. > >> > > > > Could you suggest m

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Florian Fainelli wrote: Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call this for every packet just to make a led blink. Could you suggest me a better way to do so ? The code was highly inspired from what is done with the I

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Florian Fainelli
Hello Patrick, Le mercredi 18 juillet 2007, Patrick McHardy a écrit : > Module isn't possible, you call the led trigger from net/core/dev.c. You are right, it just occured to me. > Besides missing a declaration and not linking without the network > LED config option, its pretty ridiculous to cal

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Stephen Hemminger
On Wed, 18 Jul 2007 15:27:38 +0200 Florian Fainelli <[EMAIL PROTECTED]> wrote: > Hi all, > > This patch adds a new LED trigger, based on network activity. It gathers > activity from net/core/dev.c and can be used as a LED trigger by > specifying "network-activity". Further version should allow

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Patrick McHardy
Florian Fainelli wrote: > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 87d2046..fdc5a8a 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -128,5 +128,12 @@ config LEDS_TRIGGER_HEARTBEAT > load average. > If unsure, say Y. > > +config LEDS_TR