Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread marcelo . leitner
On Fri, Jan 20, 2017 at 11:32:09AM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Fri, 20 Jan 2017 11:58:45 -0200 > > > Not sure I can add the Fixes tag for you here, but: > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > > Acked-by: Marcelo Ricardo Leitner > > FWI

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 11:31:17AM -0500, David Miller wrote: > From: Colin King > Date: Fri, 20 Jan 2017 13:45:42 + > > > From: Colin Ian King > > > > Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so > > add this in. Also compare timeout with the size of the array > > sctp_timer_

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 20 Jan 2017 14:48:20 -0200 > Seems you applied it on net tree, but commit that introduced the issue > (7b9438de0cd4) is still only on net-next. That explains everything. > I build-tested it here before acking, it worked, on top of > 4567d686f5c6d955e57a3

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 20 Jan 2017 11:58:45 -0200 > Not sure I can add the Fixes tag for you here, but: > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > Acked-by: Marcelo Ricardo Leitner FWIW, patchwork doesn't notice updated Fixes: tags like this but I try to do so m

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread David Miller
From: Colin King Date: Fri, 20 Jan 2017 13:45:42 + > From: Colin Ian King > > Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so > add this in. Also compare timeout with the size of the array > sctp_timer_tbl rather than SCTP_EVENT_TIMEOUT_MAX. Also add > a build time check that SC

Re: [PATCH][V2] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-20 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:45:42PM +, Colin King wrote: > From: Colin Ian King > > Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so > add this in. Also compare timeout with the size of the array > sctp_timer_tbl rather than SCTP_EVENT_TIMEOUT_MAX. Also add > a build time check that