Re: [1/1] net: pegasus: remove dead coding

2016-05-18 Thread Petko Manolov
On 16-05-18 09:15:40, Oliver Neukum wrote: > On Tue, 2016-05-17 at 23:30 -0700, Guenter Roeck wrote: > > On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote: > > > (!count || count < 4) is always true. > > > > Even if count >= 4 ? > > The check for !count is redundant, though. Gcc

Re: [1/1] net: pegasus: remove dead coding

2016-05-18 Thread Oliver Neukum
On Tue, 2016-05-17 at 23:30 -0700, Guenter Roeck wrote: > On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote: > > (!count || count < 4) is always true. > > Even if count >= 4 ? The check for !count is redundant, though. Gcc, however, will surely simplify the expression.

Re: [1/1] net: pegasus: remove dead coding

2016-05-17 Thread Guenter Roeck
On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote: > (!count || count < 4) is always true. Even if count >= 4 ? Guenter > So let's remove the coding which is dead at least since 2005. > > Signed-off-by: Heinrich Schuchardt > > --- > drivers/net/usb/pegasus.c | 53 ---