Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Johannes Berg
> Just to ensure things get cleaned up properly, as of now it looks > like you only reverted patch 2/2 of my v2 and Arnd's fix to patch > 1/2, not patch 1/2 itself. Oops. I've fixed that up to only revert your patch - I wanted the revert in the tree to document the issue, rather than just droppin

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Michał Kępień
Mike, Johannes, sorry for the trouble caused. > Thanks for the report. I'm sorry I missed this in review - obviously we > can't call something that acquires the mutex from rfkill_set_sw_state() > which clearly states, in the documentation: > >  * This function can be called in any context, even f

Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

2016-12-19 Thread Johannes Berg
Hi Mike, Thanks for the report. I'm sorry I missed this in review - obviously we can't call something that acquires the mutex from rfkill_set_sw_state() which clearly states, in the documentation:  * This function can be called in any context, even from within rfkill  * callbacks. I've reverted