[PATCH net-next v4 4/5] virtio_net: refactor command sending and response handling

2024-06-19 Thread Heng Qi
Refactor the command handling logic by splitting virtnet_send_command_reply into virtnet_add_command_reply and virtnet_wait_command_response for better clarity and subsequent use. Signed-off-by: Heng Qi --- drivers/net/virtio_net.c | 53 1 file changed, 3

[PATCH net-next V6 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-29 Thread Andreas Roeseler
supports full sending functionality of PROBE requests, but currently does not parse the response messages, which is why Wireshark is required to verify the sent and recieved PROBE messages. The modification adds the ``-e'' flag to the command which allows the user to specify the interface

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-29 Thread Willem de Bruijn
On Mon, Mar 29, 2021 at 2:34 PM Andreas Roeseler wrote: > > On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote: > > On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler > > wrote: > > > > > > > > + if (!ext_hdr || !iio) > > > + goto send_mal_query; > > > + if (ntohs(i

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-29 Thread Andreas Roeseler
On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote: > On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler > wrote: > > > > > +   if (!ext_hdr || !iio) > > +   goto send_mal_query; > > +   if (ntohs(iio->extobj_hdr.length) <= sizeof(iio- > > >extobj_hdr)) > > +

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-28 Thread Willem de Bruijn
tion to the iputils package is still in development and can > be found here: https://github.com/Juniper-Clinic-2020/iputils.git. It > supports full sending functionality of PROBE requests, but currently > does not parse the response messages, which is why Wireshark is required > to verify the sent

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-24 Thread Andreas Roeseler
On Wed, 2021-03-24 at 20:47 +0100, Eric Dumazet wrote: > > > On 3/24/21 7:18 PM, Andreas Roeseler wrote: > > Modify the icmp_rcv function to check PROBE messages and call > > icmp_echo > > if a PROBE request is detected. > > > > > ... > > > @@ -1340,6 +1440,7 @@ static int __net_init icmp_sk_

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-24 Thread Eric Dumazet
On 3/24/21 7:18 PM, Andreas Roeseler wrote: > Modify the icmp_rcv function to check PROBE messages and call icmp_echo > if a PROBE request is detected. > ... > @@ -1340,6 +1440,7 @@ static int __net_init icmp_sk_init(struct net *net) > > /* Control parameters for ECHO replies. */ >

[PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-24 Thread Andreas Roeseler
supports full sending functionality of PROBE requests, but currently does not parse the response messages, which is why Wireshark is required to verify the sent and recieved PROBE messages. The modification adds the ``-e'' flag to the command which allows the user to specify the interface

[PATCH net-next 3/7] bnxt_en: don't fake firmware response success when PCI is disabled

2021-03-22 Thread Michael Chan
From: Edwin Peer The original intent here is to allow commands during reset to succeed without error when the device is disabled, to ensure that cleanup completes normally during NIC close, where firmware is not necessarily expected to respond. The problem with faking success during reset's PCI

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-20 Thread David Ahern
On 3/20/21 10:01 AM, Andreas Roeseler wrote: > On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote: >> On 3/17/21 9:19 PM, David Miller wrote: >>> From: Andreas Roeseler >>> Date: Wed, 17 Mar 2021 22:11:47 -0500 >>> On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: Is there so

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-20 Thread Andreas Roeseler
On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote: > On 3/17/21 9:19 PM, David Miller wrote: > > From: Andreas Roeseler > > Date: Wed, 17 Mar 2021 22:11:47 -0500 > > > > > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > > > Is there something that I'm not understanding about comp

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread David Ahern
On 3/17/21 9:19 PM, David Miller wrote: > From: Andreas Roeseler > Date: Wed, 17 Mar 2021 22:11:47 -0500 > >> On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: >> Is there something that I'm not understanding about compiling kernel >> components modularly? How do I avoid this error? >

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread David Miller
From: Andreas Roeseler Date: Wed, 17 Mar 2021 22:11:47 -0500 > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > Is there something that I'm not understanding about compiling kernel > components modularly? How do I avoid this error? > You cannot reference module exported symbols fro

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread Andreas Roeseler
On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > Hi Andreas, > > [FYI, it's a private test report for your RFC patch.] > [auto build test ERROR on net-next/master] > > url:    > https://github.com/0day-ci/linux/commits/Andreas-Roeseler/add-support-for-RFC-8335-PROBE/20210315-005052

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-15 Thread Willem de Bruijn
On Mon, Mar 15, 2021 at 3:10 PM Andreas Roeseler wrote: > > On Mon, 2021-03-15 at 11:50 -0400, Willem de Bruijn wrote: > > On Sun, Mar 14, 2021 at 12:50 PM Andreas Roeseler > > wrote: > > > > > > Modify the icmp_rcv function to check PROBE messages and call > > > icmp_echo > > > if a PROBE reques

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-15 Thread Andreas Roeseler
On Mon, 2021-03-15 at 11:50 -0400, Willem de Bruijn wrote: > On Sun, Mar 14, 2021 at 12:50 PM Andreas Roeseler > wrote: > > > > Modify the icmp_rcv function to check PROBE messages and call > > icmp_echo > > if a PROBE request is detected. > > > > Modify the existing icmp_echo function to respon

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-15 Thread Willem de Bruijn
On Sun, Mar 14, 2021 at 12:50 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check PROBE messages and call icmp_echo > if a PROBE request is detected. > > Modify the existing icmp_echo function to respond ot both ping and PROBE > requests. > > This was tested using a custom modific

[PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-14 Thread Andreas Roeseler
Modify the icmp_rcv function to check PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond ot both ping and PROBE requests. This was tested using a custom modification to the iputils package and wireshark. It supports IPV4 probing by

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-25 Thread Willem de Bruijn
On Wed, Feb 24, 2021 at 6:21 PM Andreas Roeseler wrote: > > On Sun, 2021-02-21 at 23:49 -0500, Willem de Bruijn wrote: > On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler > wrote: > > > > Modify the icmp_rcv function to check for PROBE messages and call > > icmp_echo if a PROBE request is detected

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-24 Thread Andreas Roeseler
On Sun, 2021-02-21 at 23:49 -0500, Willem de Bruijn wrote: On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-21 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping and PROBE > requests. > > This was tested using a custom modi

[PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-17 Thread Andreas Roeseler
Modify the icmp_rcv function to check for PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond to both ping and PROBE requests. This was tested using a custom modification of the iputils package and wireshark. It supports IPV4 probing

Re: [PATCH V2 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-04 Thread Andreas Roeseler
2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Type | Code | Checksum | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Identifier |Sequence Number| Reserved

Re: [PATCH V2 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 15:24:55 -0800 Andreas Roeseler wrote: > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping and PROBE > requests. > > This was tested using a custom mo

Re: [PATCH V2 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-04 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 6:30 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping and PROBE > requests. > > This was tested using a custom modif

[PATCH V2 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-03 Thread Andreas Roeseler
Modify the icmp_rcv function to check for PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond to both ping and PROBE requests. This was tested using a custom modification of the iputils package and wireshark. It supports IPV4 probing

Fw: [Bug 211085] New: No response from TCP connection in ESTALISHED state if sending data segment with unacceptable ACK

2021-01-08 Thread Stephen Hemminger
forwarded message: Date: Fri, 08 Jan 2021 08:17:40 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 211085] New: No response from TCP connection in ESTALISHED state if sending data segment with unacceptable ACK https://bugzilla.kernel.org/show_bug.cgi?id

Re: [PATCH v2] net/ncsi: Use real net-device for response handler

2020-12-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 23 Dec 2020 13:55:23 +0800 you wrote: > When aggregating ncsi interfaces and dedicated interfaces to bond > interfaces, the ncsi response handler will use the wrong net device to > find ncsi_dev, so that

[PATCH v2] net/ncsi: Use real net-device for response handler

2020-12-22 Thread John Wang
When aggregating ncsi interfaces and dedicated interfaces to bond interfaces, the ncsi response handler will use the wrong net device to find ncsi_dev, so that the ncsi interface will not work properly. Here, we use the original net device to fix it. Fixes: 138635cc27c9 ("net/ncsi: NCSI res

Re: [External] Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread John Wang
ing ncsi interfaces and dedicated interfaces to bond > > > > interfaces, the ncsi response handler will use the wrong net device > > > > to > > > > find ncsi_dev, so that the ncsi interface will not work properly. > > > > Here, we use the net device register

[PATCH AUTOSEL 5.4 111/130] iwlwifi: mvm: validate firmware sync response size

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit b570e5b0592a56c5990ae3aa0fdb93dd9b545d43 ] We send some data to the firmware and expect to get it back, but we shouldn't really trust the firmware on this. Check the size of all the data we send down to avoid using bad or just uninitialized data when the fir

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread Jakub Kicinski
On Tue, 22 Dec 2020 10:38:21 -0800 Samuel Mendoza-Jonas wrote: > On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote: > > On Sun, 20 Dec 2020 at 12:40, John Wang wrote: > > > When aggregating ncsi interfaces and dedicated interfaces to bond > > > interfaces, the ncs

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread Samuel Mendoza-Jonas
On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote: > On Sun, 20 Dec 2020 at 12:40, John Wang < > wangzhiqiang...@bytedance.com> wrote: > > > > When aggregating ncsi interfaces and dedicated interfaces to bond > > interfaces, the ncsi response handler will u

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-21 Thread Joel Stanley
On Sun, 20 Dec 2020 at 12:40, John Wang wrote: > > When aggregating ncsi interfaces and dedicated interfaces to bond > interfaces, the ncsi response handler will use the wrong net device to > find ncsi_dev, so that the ncsi interface will not work properly. > Here, we use

[PATCH] net/ncsi: Use real net-device for response handler

2020-12-20 Thread John Wang
When aggregating ncsi interfaces and dedicated interfaces to bond interfaces, the ncsi response handler will use the wrong net device to find ncsi_dev, so that the ncsi interface will not work properly. Here, we use the net device registered to packet_type to fix it. Fixes: 138635cc27c9 (&quo

Re: [PATCH net-next 6/6] icmp: add response to RFC 8335 PROBE messages

2020-12-04 Thread David Ahern
On 12/3/20 8:17 PM, Andreas Roeseler wrote: > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c > index 005faea415a4..313061b60387 100644 > --- a/net/ipv4/icmp.c > +++ b/net/ipv4/icmp.c > @@ -984,20 +984,121 @@ static bool icmp_redirect(struct sk_buff *skb) > static bool icmp_echo(struct sk_buff *skb

[PATCH net-next 6/6] icmp: add response to RFC 8335 PROBE messages

2020-12-03 Thread Andreas Roeseler
Modify the icmp_rcv function to check for PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond to both ping and PROBE requests. This was tested using a custom modification of the iputils package and wireshark. It supports IPV4 probing

[PATCH net-next 16/17] rxrpc: rxkad: Don't use pskb_pull() to advance through the response packet

2020-11-23 Thread David Howells
In the rxkad security class, don't use pskb_pull() to advance through the contents of the response packet. There's no point, especially as the next and last access to the skbuff still has to allow for the wire header in the offset (which we didn't advance over). Better

Re: [PATCH net-next v2 1/9] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon Acked-by: Lijun Pan

[PATCH net-next v2 1/9] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-18 Thread Thomas Falcon
This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 23 +++ drivers/net

Re: [PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-16 Thread Thomas Falcon
On 11/14/20 5:35 PM, Jakub Kicinski wrote: On Thu, 12 Nov 2020 13:09:57 -0600 Thomas Falcon wrote: This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed

Re: [PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:09:57 -0600 Thomas Falcon wrote: > This patch introduces the infrastructure to send batched subordinate > Command Response Queue descriptors, which are used by the ibmvnic > driver to send TX frame and RX buffer descriptors. > > Signed-off-by: Thomas Falcon

Re: [RESEND PATCH] bluetooth: Set ext scan response only when it exists

2020-11-13 Thread Luiz Augusto von Dentz
Hi Marcel, Abhishek, On Sun, Sep 13, 2020 at 12:51 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > Only set extended scan response only when it exists. Otherwise, clear > > the scan response data. > > > > Per the core spec v5.2, Vol 4, Part E, 7.8.55 >

Re: [PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-13 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

[PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-12 Thread Thomas Falcon
This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 19 +++ drivers/net

[PATCH net-next 08/11] bnxt_en: Implement RX ring reset in response to buffer errors.

2020-10-04 Thread Michael Chan
On some older chips, it is necessary to do a reset when we get buffer errors associated with an RX ring. These buffer errors may become frequent if the RX ring underruns under heavy traffic. The current code does a global reset of all reasources when this happens. This works but creates a big di

[PATCH net-next 23/23] rxrpc: rxkad: Don't use pskb_pull() to advance through the response packet

2020-10-01 Thread David Howells
In the rxkad security class, don't use pskb_pull() to advance through the contents of the response packet. There's no point, especially as the next and last access to the skbuff still has to allow for the wire header in the offset (which we didn't advance over). Better

[PATCH AUTOSEL 5.8 11/29] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

[PATCH AUTOSEL 5.4 06/18] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

[PATCH AUTOSEL 4.14 4/9] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

[PATCH AUTOSEL 4.4 2/4] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

[PATCH AUTOSEL 4.9 2/5] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

[PATCH AUTOSEL 4.19 04/11] rndis_host: increase sleep time in the query-response loop

2020-09-28 Thread Sasha Levin
afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Sig

Re: [PATCH] rndis_host: increase sleep time in the query-response loop

2020-09-14 Thread David Miller
in a failed QUERY > afterwards. > > The increase of the waiting time on the side of the linux rndis host in > the command-response loop leaves the INIT process to complete and respond > to a QUERY, which comes afterwards. The WinCE devices with this special > "feature" i

Re: [RESEND PATCH] bluetooth: Set ext scan response only when it exists

2020-09-13 Thread Marcel Holtmann
Hi Abhishek, > Only set extended scan response only when it exists. Otherwise, clear > the scan response data. > > Per the core spec v5.2, Vol 4, Part E, 7.8.55 > > If the advertising set is non-scannable and the Host uses this command > other than to discard existing data,

[RESEND PATCH] bluetooth: Set ext scan response only when it exists

2020-09-11 Thread Abhishek Pandit-Subedi
Only set extended scan response only when it exists. Otherwise, clear the scan response data. Per the core spec v5.2, Vol 4, Part E, 7.8.55 If the advertising set is non-scannable and the Host uses this command other than to discard existing data, the Controller shall return the error code

[PATCH] rndis_host: increase sleep time in the query-response loop

2020-09-11 Thread Olympia Giannou
command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Signed-off-by: Olympia Giannou --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1

Re: [PATCH net-next] ibmvnic: Harden device Command Response Queue handshake

2020-09-01 Thread David Miller
From: Thomas Falcon Date: Mon, 31 Aug 2020 11:59:57 -0500 > In some cases, the device or firmware may be busy when the > driver attempts to perform the CRQ initialization handshake. > If the partner is busy, the hypervisor will return the H_CLOSED > return code. The aim of this patch is that, if

[PATCH net-next] ibmvnic: Harden device Command Response Queue handshake

2020-08-31 Thread Thomas Falcon
In some cases, the device or firmware may be busy when the driver attempts to perform the CRQ initialization handshake. If the partner is busy, the hypervisor will return the H_CLOSED return code. The aim of this patch is that, if the device is not ready, to query the device a number of times, with

Re: [PATCH net-next] ibmvnic: Fix use-after-free of VNIC login response buffer

2020-08-24 Thread David Miller
From: Thomas Falcon Date: Fri, 21 Aug 2020 13:39:01 -0500 > The login response buffer is freed after it is received > and parsed, but other functions in the driver still attempt > to read it, such as when the device is opened, causing the > Oops below. Store relevant information in

[PATCH net-next] ibmvnic: Fix use-after-free of VNIC login response buffer

2020-08-21 Thread Thomas Falcon
The login response buffer is freed after it is received and parsed, but other functions in the driver still attempt to read it, such as when the device is opened, causing the Oops below. Store relevant information in the driver's private data structures and use those instead. BUG: Kernel

[PATCH v6 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-08-18 Thread Ooi, Joyce
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

[PATCH] bluetooth: Set ext scan response only when it exists

2020-08-14 Thread Abhishek Pandit-Subedi
Only set extended scan response only when it exists. Otherwise, clear the scan response data. Per the core spec v5.2, Vol 4, Part E, 7.8.55 If the advertising set is non-scannable and the Host uses this command other than to discard existing data, the Controller shall return the error code

[PATCH v5 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-07-27 Thread Ooi, Joyce
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

Re: [PATCH v4 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-07-23 Thread Thor Thayer
On 7/8/20 2:23 AM, Ooi, Joyce wrote: From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call retur

[PATCH net v2 05/10] net/smc: drop out-of-flow llc response messages

2020-07-18 Thread Karsten Graul
To be save from unexpected or late llc response messages check if the arrived message fits to the current flow type and drop out-of-flow messages. And drop it when there is already a response assigned to the flow. Reviewed-by: Ursula Braun Fixes: ef79d439cd12 ("net/smc: process llc respons

[PATCH net v2 01/10] net/smc: handle unexpected response types for confirm link

2020-07-18 Thread Karsten Graul
2 +1051,14 @@ static int smc_llc_srv_conf_link(struct smc_link *link, if (rc) return -ENOLINK; /* receive CONFIRM LINK response over the RoCE fabric */ - qentry = smc_llc_wait(lgr, link, SMC_LLC_WAIT_FIRST_TIME, - SMC_LLC_CONFIRM_LINK);

[PATCH net 05/10] net/smc: drop out-of-flow llc response messages

2020-07-16 Thread Karsten Graul
To be save from unexpected or late llc response messages check if the arrived message fits to the current flow type and drop out-of-flow messages. And drop it when there is already a response assigned to the flow. Reviewed-by: Ursula Braun Fixes: ef79d439cd12 ("net/smc: process llc respons

[PATCH net 01/10] net/smc: handle unexpected response types for confirm link

2020-07-16 Thread Karsten Graul
2 +1051,14 @@ static int smc_llc_srv_conf_link(struct smc_link *link, if (rc) return -ENOLINK; /* receive CONFIRM LINK response over the RoCE fabric */ - qentry = smc_llc_wait(lgr, link, SMC_LLC_WAIT_FIRST_TIME, - SMC_LLC_CONFIRM_LINK);

[PATCH v4 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-07-08 Thread Ooi, Joyce
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

Your Response,

2020-06-21 Thread Mrs. Patricia Edgar
r personal search of the Country and State and i got your mail contact through search to let you know my Bitterness and please, help me now is getting very Dark I ask my Doctor to help me keep you notice failure for me to reach you in person Your Response, Thanks. Mrs. Patricia Edgar

[PATCH v3 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-06-04 Thread Ooi, Joyce
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

RE: [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-05 Thread Ooi, Joyce
t; Subject: Re: [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores > tx_buffer > call response > > From: Joyce Ooi > Date: Mon, 4 May 2020 16:25:49 +0800 > > > The return from tx_buffer call in tse_start_xmit is inapropriately > > ignored. tse_buffe

Re: [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-04 Thread David Miller
From: Joyce Ooi Date: Mon, 4 May 2020 16:25:49 +0800 > The return from tx_buffer call in tse_start_xmit is > inapropriately ignored. tse_buffer calls should return > 0 for success or NETDEV_TX_BUSY. tse_start_xmit should > return not report a successful transmit when the tse_buffer > call retu

[PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-04 Thread Joyce Ooi
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

[PATCH net-next 09/14] net/smc: move the TEST_LINK response processing into event handler

2020-04-30 Thread Karsten Graul
Get rid of the extra function and move the two-liner for the TEST_LINK response processing into the event handler function. Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun --- net/smc/smc_llc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/net/smc

[PATCH net-next v2 03/22] bnxt_en: Convert error code in firmware message response to standard code.

2019-08-29 Thread Michael Chan
The main firmware messaging function returns the firmware defined error code and many callers have to convert to standard error code for proper propagation to userspace. Convert bnxt_hwrm_do_send_msg() to return standard error code so we can do away with all the special error code handling by the

[net-next v2 11/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-14 Thread Jeff Kirsher
From: Aleksandr Loktionov Driver updated pf->flags before calling i40e_aq_start_lldp(). This patch moved down updating pf->flags down so flags will be updated only in case of successful i40e_aq_start_lldp() call. Also was introduced is_reset_needed local flag to avoid unnecessary h/w reset in cas

[net-next v2 08/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-14 Thread Jeff Kirsher
From: Piotr Marczak Driver did not check response on LLDP flag change and always returned SUCCESS. This patch now checks for an error and returns an error code and has additional information in the log. Signed-off-by: Piotr Marczak Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

Re: [net-next 08/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-14 Thread David Miller
From: Sergei Shtylyov Date: Fri, 14 Jun 2019 12:42:52 +0300 > On 13.06.2019 21:53, Jeff Kirsher wrote: > >> + "Device configuration forbids SW from starting the LLDP agent.\n"); >> +return (-EINVAL); > >() not needed. None was used above, so why have them

Re: [net-next 08/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-14 Thread Sergei Shtylyov
Hello! On 13.06.2019 21:53, Jeff Kirsher wrote: From: Piotr Marczak Driver did not check response on LLDP flag change and always returned SUCCESS. This patch now checks for an error and returns an error code and has additional information in the log. Signed-off-by: Piotr Marczak Tested-by

[net-next 08/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-13 Thread Jeff Kirsher
From: Piotr Marczak Driver did not check response on LLDP flag change and always returned SUCCESS. This patch now checks for an error and returns an error code and has additional information in the log. Signed-off-by: Piotr Marczak Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 11/12] i40e: Missing response checks in driver when starting/stopping FW LLDP

2019-06-13 Thread Jeff Kirsher
From: Aleksandr Loktionov Driver updated pf->flags before calling i40e_aq_start_lldp(). This patch moved down updating pf->flags down so flags will be updated only in case of successful i40e_aq_start_lldp() call. Also was introduced is_reset_needed local flag to avoid unnecessary h/w reset in cas

[net-next v2 02/11] i40e: change behavior on PF in response to MDD event

2019-05-03 Thread Jeff Kirsher
From: Carolyn Wyborny TX MDD events reported on the PF are the result of the PF misconfiguring a descriptor and not because of "bad actions" by anything else. No need to reset now because if it results in a Tx hang, the Tx hang check will take care of it. Signed-off-by: Carolyn Wyborny Tested-

[net-next 03/12] i40e: change behavior on PF in response to MDD event

2019-04-29 Thread Jeff Kirsher
From: Carolyn Wyborny TX MDD events reported on the PF are the result of the PF misconfiguring a descriptor and not because of "bad actions" by anything else. No need to reset now because if it results in a Tx hang, the Tx hang check will take care of it. Signed-off-by: Carolyn Wyborny Tested-

mgmt-tx issues with off-channel neighbor response on channel 100

2019-03-19 Thread Ben Greear
Hello, I'm not sure if the fault is hostapd or the wireless stack (or something else), but this is what I see: I put an AP on channel 100, configured for RRM. STA associates to it and sends a channel report request. hostapd reports tx of the response frame failed with EBUSY (-16). Debu

waiting your response

2019-03-19 Thread Mr Li-chien Weng
Hi I have an amazing recommendation for you, mercifully recognize receipt of this email by sending me an email with your own email address; wangtao...@163.com further details will be given of this worthwhile business proposition. Respects. Mr Li-chien Weng

[PATCH net 2/2] bnxt_en: Wait longer for the firmware message response to complete.

2019-02-20 Thread Michael Chan
The code waits up to 20 usec for the firmware response to complete once we've seen the valid response header in the buffer. It turns out that in some scenarios, this wait time is not long enough. Extend it to 150 usec and use usleep_range() instead of udelay(). Fixes: 9751e8e71487 (&qu

[PATCH AUTOSEL 4.20 071/105] vhost/scsi: Use copy_to_iter() to send control queue response

2019-02-12 Thread Sasha Levin
From: Bijan Mottahedeh [ Upstream commit 8e5dadfe76cf2862ebf3e4f22adef29982df7766 ] Uses copy_to_iter() instead of __copy_to_user() in order to ensure we support arbitrary layouts and an input buffer split across iov entries. Fixes: 0d02dbd68c47b ("vhost/scsi: Respond to control queue operation

Re: [PATCH v2 net-next 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-12-18 Thread Thor Thayer
Hi Dalon, On 12/13/18 11:52 AM, dwest...@gmail.com wrote: From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the

[PATCH net-next v2 02/14] octeontx2-af: Add response for RSS flow key cfg message

2018-12-02 Thread Jerin Jacob
Added response for nix_rss_flowkey_cfg message to return selected RSS algorithm index. The FLOW_KEY_TYPE* definition is part of the mbox message and it will be used by the other consumers of AF driver hence moving to mbox.h. Also renamed FLOW_* definitions to NIX_FLOW_* to avoid global name

Re: [PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS flow key cfg message

2018-12-01 Thread David Miller
From: Jerin Jacob Date: Sat, 1 Dec 2018 14:43:51 +0530 > +#define FLOW_KEY_TYPE_PORT BIT(0) > +#define FLOW_KEY_TYPE_IPV4 BIT(1) > +#define FLOW_KEY_TYPE_IPV6 BIT(2) > +#define FLOW_KEY_TYPE_TCPBIT(3) > +#define FLOW_KEY_TYPE_UDPBIT(4) > +#define FLOW_KEY_TYPE_SCTP BIT(5) This i

[PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS flow key cfg message

2018-12-01 Thread Jerin Jacob
From: Jerin Jacob Added response for nix_rss_flowkey_cfg message to return selected RSS algorithm index. The FLOW_KEY_TYPE* definition is part of the mbox message and it will be used by the other consumers of AF driver hence moving to mbox.h. Signed-off-by: Jerin Jacob --- drivers/net

Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-17 Thread Westergreen, Dalon
On Fri, 2018-11-16 at 20:38 -0800, David Miller wrote: > From: Dalon Westergreen > Date: Wed, 14 Nov 2018 16:50:40 -0800 > > > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, > struct tse_buffer *buffer) > > /* enqueue the request to the pending transmit queue */ >

Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-16 Thread David Miller
From: Dalon Westergreen Date: Wed, 14 Nov 2018 16:50:40 -0800 > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, > struct tse_buffer *buffer) > /* enqueue the request to the pending transmit queue */ > queue_tx(priv, buffer); > > - return 1; > + retu

Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer c

[PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition to

I wait for your prompt response.

2018-10-23 Thread Aziz Dake
properties, hotels and any other viable investment opportunities in your country based on your recommendation will be highly welcomed. Hence your co -operation is highly needed to actualize this investment project I wait for your prompt response. Sincerely yours Mr Aziz Dake.

[PATCH v2 12/17] octeontx2-af: Add LMAC channel info to NIXLF_ALLOC response

2018-10-22 Thread sunil . kovvuri
From: Stanislaw Kardach Add LMAC channel info like Rx/Tx channel base and count to NIXLF_ALLOC mailbox message response. This info is used by NIXLF attached RVU PF/VF to configure SQ's default channel, TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based on matching ingress channel n

[PATCH 12/17] octeontx2-af: Add LMAC channel info to NIXLF_ALLOC response

2018-10-19 Thread sunil . kovvuri
From: Stanislaw Kardach Add LMAC channel info like Rx/Tx channel base and count to NIXLF_ALLOC mailbox message response. This info is used by NIXLF attached RVU PF/VF to configure SQ's default channel, TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based on matching ingress channel n

  1   2   3   >