Re: Re: [PATCH 2/2] vsock/virtio: Don't reset the created SOCKET during s2r

2025-02-11 Thread Stefano Garzarella
Please read the links we already shared with you!!! No MIME, no links, no compression, no attachments. Just plain text https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text On Tue, 11 Feb 2025 at 06:24, 吴俊南 wrote:

RE: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch

2024-06-20 Thread Li,Rongqing
> Did you by any chance use an automated tool of any sort to find this issue or > generate the fix? > > I don't think this is actually necessary here, you're in the same context as > the > updater of the stats, you don't need any protection. > You can remove u64_stats_update_begin() / end() (in n

RE: RE: [PATCH net-next 2/2] virtio_net: Add TX stopped and wake counters

2024-05-10 Thread Dan Jurgens
> From: Xuan Zhuo > Sent: Friday, May 10, 2024 1:48 AM > To: Dan Jurgens > Cc: m...@redhat.com; jasow...@redhat.com; virtualizat...@lists.linux.dev; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; > pab...@redhat.com; Jiri Pirko ; netdev@vger.kernel.org > Subjec

Re: RE: [PATCH net-next 2/2] virtio_net: Add TX stopped and wake counters

2024-05-09 Thread Xuan Zhuo
On Fri, 10 May 2024 03:35:51 +, Dan Jurgens wrote: > > From: Xuan Zhuo > > Sent: Thursday, May 9, 2024 8:22 PM > > To: Dan Jurgens > > Cc: m...@redhat.com; jasow...@redhat.com; xuanz...@linux.alibaba.com; > > virtualizat...@lists.linux.dev; da...@davemloft.net; > > eduma...@google.com; k...@

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-16 Thread Yongji Xie
On Fri, Apr 16, 2021 at 11:24 AM Jason Wang wrote: > > > 在 2021/3/31 下午4:05, Xie Yongji 写道: > > + } > > + case VDUSE_INJECT_VQ_IRQ: > > + ret = -EINVAL; > > + if (arg >= dev->vq_num) > > + break; > > + > > + ret = 0; > > +

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Fri, Apr 16, 2021 at 10:24 AM Jason Wang wrote: > > > 在 2021/4/15 下午10:38, Stefan Hajnoczi 写道: > > On Thu, Apr 15, 2021 at 04:36:35PM +0800, Jason Wang wrote: > >> 在 2021/4/15 下午3:19, Stefan Hajnoczi 写道: > >>> On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > On Wed, Apr 14, 20

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Fri, Apr 16, 2021 at 11:03 AM Jason Wang wrote: > > > 在 2021/4/16 上午10:58, Yongji Xie 写道: > > On Fri, Apr 16, 2021 at 10:20 AM Jason Wang wrote: > >> > >> 在 2021/4/15 下午7:17, Yongji Xie 写道: > >>> On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote: > 在 2021/4/15 下午4:36, Jason Wang 写道: > >>>

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Thu, Apr 15, 2021 at 10:38 PM Stefan Hajnoczi wrote: > > On Thu, Apr 15, 2021 at 04:36:35PM +0800, Jason Wang wrote: > > > > 在 2021/4/15 下午3:19, Stefan Hajnoczi 写道: > > > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > > > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi > > >

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Fri, Apr 16, 2021 at 10:20 AM Jason Wang wrote: > > > 在 2021/4/15 下午7:17, Yongji Xie 写道: > > On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote: > >> > >> 在 2021/4/15 下午4:36, Jason Wang 写道: > Please state this explicitly at the start of the document. Existing > interfaces like FUSE are

Re: Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Stefan Hajnoczi
On Thu, Apr 15, 2021 at 04:33:27PM +0800, Yongji Xie wrote: > On Thu, Apr 15, 2021 at 3:19 PM Stefan Hajnoczi wrote: > > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi > > > wrote: > > > > On Wed, Mar 31, 2021 at 04:05:19PM +080

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote: > > > 在 2021/4/15 下午4:36, Jason Wang 写道: > >>> > >> Please state this explicitly at the start of the document. Existing > >> interfaces like FUSE are designed to avoid trusting userspace. > > > > > > There're some subtle difference here. VDUSE pres

Re: Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Thu, Apr 15, 2021 at 3:19 PM Stefan Hajnoczi wrote: > > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi > > wrote: > > > > > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > > > > VDUSE (vDPA Device in Userspace)

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Stefan Hajnoczi
On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote: > > > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > > > VDUSE (vDPA Device in Userspace) is a framework to support > > > implementing software-emulated vDPA devic

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-14 Thread Yongji Xie
On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote: > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > > VDUSE (vDPA Device in Userspace) is a framework to support > > implementing software-emulated vDPA devices in userspace. This > > document is intended to clarify the VDUSE de

Re: Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Yongji Xie
On Wed, Apr 14, 2021 at 3:35 PM Michael S. Tsirkin wrote: > > On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: > > This series introduces a framework, which can be used to implement > > vDPA Devices in a userspace program. The work consist of two parts: > > control path forwarding and d

Re: Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jiang Wang .
Hi Jorgen, Thanks for the detailed explanation and I agree with you. For the bind list, my prototype is doing something similar to that. I will double check it. Hi Stefano, I don't have other questions for now. Thanks. Regards, Jiang On Tue, Apr 13, 2021 at 5:52 AM Stefano Garzarella wrote:

Re: Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Andrew Lunn
On Tue, Apr 13, 2021 at 08:56:30AM +0200, Christian Herber wrote: > Hi Andrew, > > On 4/12/2021 6:52 PM, Andrew Lunn wrote: > > > > So what you are say is, you don't care if the IP is completely > > different, it all goes in one driver. So lets put this driver into > > nxp-tja11xx.c. And then we

Re: Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Christian Herber
Hi Andrew, On 4/12/2021 6:52 PM, Andrew Lunn wrote: So what you are say is, you don't care if the IP is completely different, it all goes in one driver. So lets put this driver into nxp-tja11xx.c. And then we avoid all the naming issues. Andrew As this seems to be a key question, let

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Yongji Xie
On Tue, Apr 13, 2021 at 11:35 AM Jason Wang wrote: > > > 在 2021/4/12 下午5:59, Yongji Xie 写道: > > On Mon, Apr 12, 2021 at 5:37 PM Jason Wang wrote: > >> > >> 在 2021/4/12 下午4:02, Yongji Xie 写道: > >>> On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: > 在 2021/4/9 下午4:02, Yongji Xie 写道: > >>

Re: Re: [RFC] vsock: add multiple transports support for dgram

2021-04-12 Thread Jiang Wang .
On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella wrote: > > Hi Jiang, > thanks for re-starting the multi-transport support for dgram! No problem. > On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote: > >On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > >> > >> > >> > On 6 Apr 20

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Yongji Xie
On Mon, Apr 12, 2021 at 5:37 PM Jason Wang wrote: > > > 在 2021/4/12 下午4:02, Yongji Xie 写道: > > On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: > >> > >> 在 2021/4/9 下午4:02, Yongji Xie 写道: > >>> +}; > >>> + > >>> +struct vduse_dev_config_data { > >>> + __u32 offset; /* offset

Re: Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-12 Thread Michael S. Tsirkin
On Mon, Apr 12, 2021 at 10:29:17AM +0800, Yongji Xie wrote: > On Mon, Apr 12, 2021 at 4:49 AM Michael S. Tsirkin wrote: > > > > On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > > > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Mar 31, 2021

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-12 Thread Yongji Xie
On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: > > > 在 2021/4/9 下午4:02, Yongji Xie 写道: > > +}; > > + > > +struct vduse_dev_config_data { > > + __u32 offset; /* offset from the beginning of config space */ > > + __u32 len; /* the length to read/write */ > > +

Re: Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-11 Thread Yongji Xie
On Mon, Apr 12, 2021 at 4:49 AM Michael S. Tsirkin wrote: > > On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote: > > > > Use vhost_dev->mutex to protect

Re: Re: BUG: Bad rss-counter state (4)

2021-04-11 Thread Vegard Nossum
(trimmed off the batman/bpf Ccs) On 2020-05-18 14:28, syzbot wrote: syzbot has bisected this bug to: commit 0d8dd67be013727ae57645ecd3ea2c36365d7da8 Author: Song Liu Date: Wed Dec 6 22:45:14 2017 + perf/headers: Sync new perf_event.h with the tools/include/uapi version bisection l

Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-11 Thread Michael S. Tsirkin
On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin wrote: > > > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote: > > > Use vhost_dev->mutex to protect vhost device iotlb from > > > concurrent access. > > > > > > Fixes: 4c8

Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-10 Thread Yongji Xie
On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin wrote: > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote: > > Use vhost_dev->mutex to protect vhost device iotlb from > > concurrent access. > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend") > > Cc: sta...@vger.kernel.or

Re: Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work

2021-04-09 Thread Jianmin Wang
On Fri, Apr 09, 2021 at 08:36:07 +0200, Greg KH > On Thu, Apr 08, 2021 at 07:11:48PM +, Jianmin Wang wrote: > > while the new services need to invoke libkcapi in the container environment. > > > > We have verified that the problem doesn't exist on newer kernel version. > > However, due to man

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-09 Thread Yongji Xie
On Fri, Apr 9, 2021 at 1:36 PM Jason Wang wrote: > > > 在 2021/4/8 下午5:36, Yongji Xie 写道: > > On Thu, Apr 8, 2021 at 2:57 PM Jason Wang wrote: > >> > >> 在 2021/3/31 下午4:05, Xie Yongji 写道: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> Both control path and data path

Re: Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 07:11:48PM +, Jianmin Wang wrote: > On Mon, Apr 05, 2021 at 16:14 UTC, Greg KH wrote: > > On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote: > > > There is same problem found in linux 4.19.y as upstream commit. The > > > changes of crypto_user_* and cryptouse

Re: Re: [PATCH] backports: crypto user - make NETLINK_CRYPTO work

2021-04-08 Thread Jianmin Wang
On Mon, Apr 05, 2021 at 16:14 UTC, Greg KH wrote: > On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote: > > There is same problem found in linux 4.19.y as upstream commit. The > > changes of crypto_user_* and cryptouser.h files from upstream patch are > > merged into > > crypto/crypto_

Re: Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-08 Thread Yongji Xie
On Thu, Apr 8, 2021 at 2:57 PM Jason Wang wrote: > > > 在 2021/3/31 下午4:05, Xie Yongji 写道: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VDUSE dr

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-08 Thread Yongji Xie
On Thu, Apr 8, 2021 at 3:18 PM Jason Wang wrote: > > > 在 2021/3/31 下午4:05, Xie Yongji 写道: > > VDUSE (vDPA Device in Userspace) is a framework to support > > implementing software-emulated vDPA devices in userspace. This > > document is intended to clarify the VDUSE design and usage. > > > > Signed

Re: Re: [PATCH v6 08/10] vduse: Implement an MMU-based IOMMU driver

2021-04-07 Thread Yongji Xie
On Thu, Apr 8, 2021 at 11:26 AM Jason Wang wrote: > > > 在 2021/3/31 下午4:05, Xie Yongji 写道: > > This implements an MMU-based IOMMU driver to support mapping > > kernel dma buffer into userspace. The basic idea behind it is > > treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set > > up MM

RE: Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

2021-04-01 Thread Kostya Porotchkin
Hi, Randy, > -Original Message- > From: Randy Dunlap > Sent: Wednesday, March 31, 2021 18:28 > To: Stephen Rothwell ; Linux Next Mailing List n...@vger.kernel.org> > Cc: Linux Kernel Mailing List ; Kostya > Porotchkin ; netdev@vger.kernel.org > Subject: [EXT] Re: linux-next: Tree for Mar

Re: Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Yongji Xie
On Wed, Mar 31, 2021 at 10:08 PM Christian Brauner wrote: > > On Wed, Mar 31, 2021 at 09:59:07PM +0800, Yongji Xie wrote: > > On Wed, Mar 31, 2021 at 8:23 PM Christian Brauner > > wrote: > > > > > > On Wed, Mar 31, 2021 at 07:32:33PM +0800, Yongji Xie wrote: > > > > On Wed, Mar 31, 2021 at 5:15 P

Re: Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Yongji Xie
On Wed, Mar 31, 2021 at 8:23 PM Christian Brauner wrote: > > On Wed, Mar 31, 2021 at 07:32:33PM +0800, Yongji Xie wrote: > > On Wed, Mar 31, 2021 at 5:15 PM Christian Brauner > > wrote: > > > > > > On Wed, Mar 31, 2021 at 04:05:10PM +0800, Xie Yongji wrote: > > > > Export receive_fd() so that som

Re: Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Yongji Xie
On Wed, Mar 31, 2021 at 5:15 PM Christian Brauner wrote: > > On Wed, Mar 31, 2021 at 04:05:10PM +0800, Xie Yongji wrote: > > Export receive_fd() so that some modules can use > > it to pass file descriptor between processes without > > missing any security stuffs. > > > > Signed-off-by: Xie Yongji

Re: Re: [PATCH] net/rds: Fix a use after free in rds_message_map_pages

2021-03-30 Thread lyl2019
> -原始邮件- > 发件人: "David Miller" > 发送时间: 2021-03-31 08:02:28 (星期三) > 收件人: lyl2...@mail.ustc.edu.cn > 抄送: santosh.shilim...@oracle.com, k...@kernel.org, netdev@vger.kernel.org, > linux-r...@vger.kernel.org, rds-de...@oss.oracle.com, > linux-ker...@vger.kernel.org > 主题: Re: [PATCH] net/rd

Re: Re: [PATCH] ethernet/realtek/r8169: Fix a double free in rtl8169_start_xmit

2021-03-29 Thread lyl2019
> -原始邮件- > 发件人: "Heiner Kallweit" > 发送时间: 2021-03-29 17:51:30 (星期一) > 收件人: "Lv Yunlong" , nic_s...@realtek.com, > k...@kernel.org > 抄送: netdev@vger.kernel.org, linux-ker...@vger.kernel.org > 主题: Re: [PATCH] ethernet/realtek/r8169: Fix a double free in > rtl8169_start_xmit > > On 29.0

Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Yongji Xie
On Fri, Mar 26, 2021 at 2:16 PM Jason Wang wrote: > > > 在 2021/3/26 下午1:14, Yongji Xie 写道: > > + } > + map->bounce_page = page; > + > + /* paired with vduse_domain_map_page() */ > + smp_mb(); > > So this is suspicious. It's better to explain like, we need make sure A > must be done

Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Yongji Xie
On Fri, Mar 26, 2021 at 12:27 PM Jason Wang wrote: > > > 在 2021/3/25 下午3:38, Yongji Xie 写道: > > On Thu, Mar 25, 2021 at 12:53 PM Jason Wang wrote: > >> > >> 在 2021/3/24 下午3:39, Yongji Xie 写道: > >>> On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: > 在 2021/3/15 下午1:37, Xie Yongji 写道: > >>>

Re: Re: [PATCH v5 01/11] file: Export __receive_fd() to modules

2021-03-25 Thread Yongji Xie
On Thu, Mar 25, 2021 at 4:25 PM Christoph Hellwig wrote: > > On Mon, Mar 15, 2021 at 05:46:43PM +0800, Yongji Xie wrote: > > On Mon, Mar 15, 2021 at 5:08 PM Christoph Hellwig > > wrote: > > > > > > On Mon, Mar 15, 2021 at 01:37:11PM +0800, Xie Yongji wrote: > > > > Export __receive_fd() so that

Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Yongji Xie
On Thu, Mar 25, 2021 at 12:53 PM Jason Wang wrote: > > > 在 2021/3/24 下午3:39, Yongji Xie 写道: > > On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: > >> > >> 在 2021/3/15 下午1:37, Xie Yongji 写道: > >>> This implements an MMU-based IOMMU driver to support mapping > >>> kernel dma buffer into userspace

Re: Re: [PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-25 Thread Yongji Xie
On Thu, Mar 25, 2021 at 2:31 PM Jason Wang wrote: > > > 在 2021/3/24 下午4:55, Yongji Xie 写道: > > On Wed, Mar 24, 2021 at 12:43 PM Jason Wang wrote: > >> > >> 在 2021/3/15 下午1:37, Xie Yongji 写道: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> Both control path and data p

Re: Re: [PATCH v5 10/11] vduse: Add config interrupt support

2021-03-24 Thread Yongji Xie
On Wed, Mar 24, 2021 at 12:45 PM Jason Wang wrote: > > > 在 2021/3/15 下午1:37, Xie Yongji 写道: > > This patch introduces a new ioctl VDUSE_INJECT_CONFIG_IRQ > > to support injecting config interrupt. > > > > Signed-off-by: Xie Yongji > > > I suggest to squash this into path 9. > Will do it in v6.

Re: Re: [PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-24 Thread Yongji Xie
On Wed, Mar 24, 2021 at 12:43 PM Jason Wang wrote: > > > 在 2021/3/15 下午1:37, Xie Yongji 写道: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VDUSE

Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-24 Thread Yongji Xie
On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: > > > 在 2021/3/15 下午1:37, Xie Yongji 写道: > > This implements an MMU-based IOMMU driver to support mapping > > kernel dma buffer into userspace. The basic idea behind it is > > treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set > > up M

Re: Re: [PATCH] net/mlx5: Fix a potential use after free in mlx5e_ktls_del_rx

2021-03-23 Thread lyl2019
> -原始邮件- > 发件人: "Maxim Mikityanskiy" > 发送时间: 2021-03-23 16:52:07 (星期二) > 收件人: "Lv Yunlong" , bor...@nvidia.com, > sae...@nvidia.com, l...@kernel.org, da...@davemloft.net, k...@kernel.org, > maxi...@mellanox.com > 抄送: netdev@vger.kernel.org, linux-r...@vger.kernel.org, > linux-ker...@

Re: Re: [PATCH v5 07/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-23 Thread Yongji Xie
On Tue, Mar 23, 2021 at 11:13 AM Jason Wang wrote: > > > 在 2021/3/15 下午1:37, Xie Yongji 写道: > > This patch introduces an attribute for vDPA device to indicate > > whether virtual address can be used. If vDPA device driver set > > it, vhost-vdpa bus driver will not pin user page and transfer > > us

Re: Re: [PATCH v5 03/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-23 Thread Yongji Xie
On Tue, Mar 23, 2021 at 11:02 AM Jason Wang wrote: > > > 在 2021/3/15 下午1:37, Xie Yongji 写道: > > Use vhost_dev->mutex to protect vhost device iotlb from > > concurrent access. > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend") > > Signed-off-by: Xie Yongji > > > Acked-by: Jason Wang >

Re: Re: [PATCH v5 01/11] file: Export __receive_fd() to modules

2021-03-15 Thread Yongji Xie
On Mon, Mar 15, 2021 at 10:44 PM Christian Brauner wrote: > > On Mon, Mar 15, 2021 at 05:46:43PM +0800, Yongji Xie wrote: > > On Mon, Mar 15, 2021 at 5:08 PM Christoph Hellwig > > wrote: > > > > > > On Mon, Mar 15, 2021 at 01:37:11PM +0800, Xie Yongji wrote: > > > > Export __receive_fd() so that

Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-15 Thread Tom Parkin
On Mon, Mar 15, 2021 at 13:18:24 +0100, Guillaume Nault wrote: > On Fri, Mar 12, 2021 at 10:47:53PM +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > > > > > -原始邮件- > > > 发件人: "Tom Parkin" > > > 发送时间: 2021-03-12 18:12:58 (星期五) > > > 收件人: lyl2...@mail.ustc.edu.cn > > > 抄送: pau...@samba.o

Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-15 Thread Guillaume Nault
On Fri, Mar 12, 2021 at 10:47:53PM +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > -原始邮件- > > 发件人: "Tom Parkin" > > 发送时间: 2021-03-12 18:12:58 (星期五) > > 收件人: lyl2...@mail.ustc.edu.cn > > 抄送: pau...@samba.org, da...@davemloft.net, linux-...@vger.kernel.org, > > netdev@vger.kernel.org, l

Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-15 Thread Tom Parkin
On Fri, Mar 12, 2021 at 22:47:53 +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > -原始邮件- > > 发件人: "Tom Parkin" > > 发送时间: 2021-03-12 18:12:58 (星期五) > > 收件人: lyl2...@mail.ustc.edu.cn > > 抄送: pau...@samba.org, da...@davemloft.net, linux-...@vger.kernel.org, > > netdev@vger.kernel.org, li

Re: Re: [PATCH v5 01/11] file: Export __receive_fd() to modules

2021-03-15 Thread Yongji Xie
On Mon, Mar 15, 2021 at 5:08 PM Christoph Hellwig wrote: > > On Mon, Mar 15, 2021 at 01:37:11PM +0800, Xie Yongji wrote: > > Export __receive_fd() so that some modules can use > > it to pass file descriptor between processes. > > I really don't think any non-core code should do that, especilly not

Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-12 Thread lyl2019
> -原始邮件- > 发件人: "Tom Parkin" > 发送时间: 2021-03-12 18:12:58 (星期五) > 收件人: lyl2...@mail.ustc.edu.cn > 抄送: pau...@samba.org, da...@davemloft.net, linux-...@vger.kernel.org, > netdev@vger.kernel.org, linux-ker...@vger.kernel.org > 主题: Re: [BUG] net/ppp: A use after free in ppp_unregister_chan

Re: Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-10 Thread Yongji Xie
On Wed, Mar 10, 2021 at 8:58 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > + > > + switch (cmd) { > > + case VDUSE_IOTLB_GET_FD: { > > + struct vduse_iotlb_entry entry; > > + struct vhost_iotlb_map *map; > > + struct vdpa_map_fil

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 3:02 PM Jason Wang wrote: > > > On 2021/3/8 12:50 下午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: > >> > >> On 2021/3/5 4:12 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > On 2021/3/5 3:27 下午, Yongji Xie wrot

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 3:04 PM Jason Wang wrote: > > > On 2021/3/8 1:05 下午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: > >> > >> On 2021/3/8 11:45 上午, Yongji Xie wrote: > >>> On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > On 2021/3/5 3:59 下午, Yongji Xie wro

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: > > > On 2021/3/8 11:45 上午, Yongji Xie wrote: > > On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > >> > >> On 2021/3/5 3:59 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > On 2021/3/5 3:13 下午, Yongji Xie wro

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: > > > On 2021/3/5 4:12 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > >> > >> On 2021/3/5 3:27 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > On 2021/3/5 2:36 下午, Yongji Xie wrote

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Yongji Xie
On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: > > > On 2021/3/5 3:59 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > >> > >> On 2021/3/5 3:13 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > On 2021/3/5 2:15 下午, Yongji Xie wrote

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-05 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > > > On 2021/3/5 3:27 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > >> > >> On 2021/3/5 2:36 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > On 2021/3/5 11:30 上午, Yongji Xie wrot

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > > > On 2021/3/5 3:13 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > >> > >> On 2021/3/5 2:15 下午, Yongji Xie wrote: > >> > >> Sorry if I've asked this before. > >> > >> But what's the reason for maintaing a dedicated

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > > > On 2021/3/5 2:36 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > >> > >> On 2021/3/5 11:30 上午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: > On 2021/3/4 4:58 下午, Yongji Xie wro

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > > > On 2021/3/5 2:15 下午, Yongji Xie wrote: > > Sorry if I've asked this before. > > But what's the reason for maintaing a dedicated IOTLB here? I think we > could reuse vduse_dev->iommu since the device can not be used by both > virtio and vhost i

Re: Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:44 AM Jason Wang wrote: > > > On 2021/3/5 11:37 上午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:11 AM Jason Wang wrote: > >> > >> On 2021/3/4 4:19 下午, Yongji Xie wrote: > >>> On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: > On 2021/2/23 7:50 下午, Xie Yongji wr

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > > > On 2021/3/5 11:30 上午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: > >> > >> On 2021/3/4 4:58 下午, Yongji Xie wrote: > >>> On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: > On 2021/2/23 7:50 下午, Xie Yongji wr

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:36 AM Jason Wang wrote: > > > On 2021/3/4 1:12 下午, Yongji Xie wrote: > > On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: > >> > >> On 2021/2/23 7:50 下午, Xie Yongji wrote: > >>> This implements a MMU-based IOMMU driver to support mapping > >>> kernel dma buffer into use

Re: Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:20 AM Jason Wang wrote: > > > On 2021/3/4 4:05 下午, Yongji Xie wrote: > > On Thu, Mar 4, 2021 at 2:27 PM Jason Wang wrote: > >> > >> On 2021/2/23 7:50 下午, Xie Yongji wrote: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> Both control path and

Re: Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:11 AM Jason Wang wrote: > > > On 2021/3/4 4:19 下午, Yongji Xie wrote: > > On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: > >> > >> On 2021/2/23 7:50 下午, Xie Yongji wrote: > >>> Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support > >>> injecting virtqueue's inte

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: > > > On 2021/3/4 4:58 下午, Yongji Xie wrote: > > On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: > >> > >> On 2021/2/23 7:50 下午, Xie Yongji wrote: > >>> This patch introduces a workqueue to support injecting > >>> virtqueue's interrupt asynchrono

Re: Re: [RFC v4 09/11] Documentation: Add documentation for VDUSE

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:40 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > VDUSE (vDPA Device in Userspace) is a framework to support > > implementing software-emulated vDPA devices in userspace. This > > document is intended to clarify the VDUSE design and usage. > > > > S

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This patch introduces a workqueue to support injecting > > virtqueue's interrupt asynchronously. This is mainly > > for performance considerations which makes sure the push() > > and pop() for used v

Re: Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support > > injecting virtqueue's interrupt to the specified cpu. > > > How userspace know which CPU is this irq for? It looks to me we need to >

Re: Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:27 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VDU

Re: Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Yongji Xie
On Thu, Mar 4, 2021 at 11:07 AM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This patch introduces an attribute for vDPA device to indicate > > whether virtual address can be used. If vDPA device driver set > > it, vhost-vdpa bus driver will not pin user page and transfer >

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-03 Thread Yongji Xie
On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This implements a MMU-based IOMMU driver to support mapping > > kernel dma buffer into userspace. The basic idea behind it is > > treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set > > u

Re: Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Yongji Xie
On Wed, Mar 3, 2021 at 6:52 PM Mika Penttilä wrote: > > > > On 23.2.2021 13.50, Xie Yongji wrote: > > This patch introduces an attribute for vDPA device to indicate > > whether virtual address can be used. If vDPA device driver set > > it, vhost-vdpa bus driver will not pin user page and transfer

Re: Re: [RFC v4 01/11] eventfd: Increase the recursion depth of eventfd_signal()

2021-03-02 Thread Yongji Xie
On Tue, Mar 2, 2021 at 2:44 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Increase the recursion depth of eventfd_signal() to 1. This > > is the maximum recursion depth we have found so far. > > > > Signed-off-by: Xie Yongji > > > Acked-by: Jason Wang > > It might be use

Re: Re: [RFC v4 02/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-02 Thread Yongji Xie
On Tue, Mar 2, 2021 at 2:47 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Use vhost_dev->mutex to protect vhost device iotlb from > > concurrent access. > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend") > > Signed-off-by: Xie Yongji > > --- > > drivers/vhos

Re: Re: [PATCH] iwlegacy: Add missing check in il4965_commit_rxon

2021-02-28 Thread dinghao . liu
> On Sun, Feb 28, 2021 at 08:25:22PM +0800, Dinghao Liu wrote: > > There is one il_set_tx_power() call in this function without > > return value check. Print error message and return error code > > on failure just like the other il_set_tx_power() call. > > We have few calls for il_set_tx_power(),

Re: RE: [PATCH v7 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-17 Thread John Fastabend
Xuan Zhuo wrote: > On Wed, 17 Feb 2021 16:46:04 -0800, John Fastabend > wrote: > > Alexander Lobakin wrote: > > > From: Xuan Zhuo > > > > > > This patch is used to construct skb based on page to save memory copy > > > overhead. > > > > > > This function is implemented based on IFF_TX_SKB_NO_LINE

Re: Re: KASAN: use-after-free Read in rxrpc_send_data_packet

2021-02-01 Thread syzbot
> #syz test: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > 7ef09ba11b33e371c9a8510c1f56e40aa0862c65 This crash does not have a reproducer. I cannot test it. >

Re: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-30 Thread Yongji Xie
On Fri, Jan 29, 2021 at 11:04 PM Stefano Garzarella wrote: > > On Thu, Jan 28, 2021 at 11:11:49AM +0800, Jason Wang wrote: > > > >On 2021/1/27 下午4:57, Stefano Garzarella wrote: > >>On Wed, Jan 27, 2021 at 11:33:03AM +0800, Jason Wang wrote: > >>> > >>>On 2021/1/20 下午7:08, Stefano Garzarella wrote:

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 2:14 PM Jason Wang wrote: > > > On 2021/1/28 下午2:03, Yongji Xie wrote: > > + > > +static const struct file_operations vduse_domain_fops = { > > + .mmap = vduse_domain_mmap, > > + .release = vduse_domain_release, > > +}; > It's better to expl

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 12:31 PM Jason Wang wrote: > > > On 2021/1/28 上午11:52, Yongji Xie wrote: > > On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: > >> > >> On 2021/1/27 下午5:11, Yongji Xie wrote: > >>> On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > On 2021/1/20 下午2:52, Yongji Xie

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 12:27 PM Jason Wang wrote: > > > On 2021/1/27 下午4:50, Yongji Xie wrote: > > On Tue, Jan 26, 2021 at 4:09 PM Jason Wang wrote: > >> > >> On 2021/1/19 下午1:07, Xie Yongji wrote: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> Both control path

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 11:08 AM Jens Axboe wrote: > > On 1/27/21 8:04 PM, Jason Wang wrote: > > > > On 2021/1/27 下午5:11, Yongji Xie wrote: > >> On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > >>> > >>> On 2021/1/20 下午2:52, Yongji Xie wrote: > On Wed, Jan 20, 2021 at 12:24 PM Jason Wang

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: > > > On 2021/1/27 下午5:11, Yongji Xie wrote: > > On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > >> > >> On 2021/1/20 下午2:52, Yongji Xie wrote: > >>> On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: > On 2021/1/19 下午12:59, Xie Yongji

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Tue, Jan 26, 2021 at 4:09 PM Jason Wang wrote: > > > On 2021/1/19 下午1:07, Xie Yongji wrote: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VD

Re: Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-27 Thread Yongji Xie
On Wed, Jan 27, 2021 at 11:51 AM Jason Wang wrote: > > > On 2021/1/20 下午3:52, Yongji Xie wrote: > > On Wed, Jan 20, 2021 at 2:24 PM Jason Wang wrote: > >> > >> On 2021/1/19 下午12:59, Xie Yongji wrote: > >>> Add an opaque pointer for vhost IOTLB to store the > >>> corresponding vma->vm_file and off

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > > > On 2021/1/20 下午2:52, Yongji Xie wrote: > > On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: > >> > >> On 2021/1/19 下午12:59, Xie Yongji wrote: > >>> Now we have a global percpu counter to limit the recursion depth > >>> of eventfd_signal()

Re: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-27 Thread Yongji Xie
On Wed, Jan 27, 2021 at 4:59 PM Stefano Garzarella wrote: > > On Tue, Jan 19, 2021 at 12:59:12PM +0800, Xie Yongji wrote: > >With VDUSE, we should be able to support all kinds of virtio devices. > > > >Signed-off-by: Xie Yongji > >--- > > drivers/vhost/vdpa.c | 29 +++-- >

Re: Re: [RFC v3 11/11] vduse: Introduce a workqueue for irq injection

2021-01-27 Thread Yongji Xie
On Tue, Jan 26, 2021 at 4:17 PM Jason Wang wrote: > > > On 2021/1/19 下午1:07, Xie Yongji wrote: > > This patch introduces a dedicated workqueue for irq injection > > so that we are able to do some performance tuning for it. > > > > Signed-off-by: Xie Yongji > > > If we want the split like this. >

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Tue, Jan 26, 2021 at 4:19 PM Jason Wang wrote: > > > On 2021/1/19 下午1:07, Xie Yongji wrote: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VDU

Re: Re: [RFC v3 10/11] vduse: grab the module's references until there is no vduse device

2021-01-27 Thread Yongji Xie
On Tue, Jan 26, 2021 at 4:10 PM Jason Wang wrote: > > > On 2021/1/19 下午1:07, Xie Yongji wrote: > > The module should not be unloaded if any vduse device exists. > > So increase the module's reference count when creating vduse > > device. And the reference count is kept until the device is > > dest

Re: Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 2:24 PM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > Add an opaque pointer for vhost IOTLB to store the > > corresponding vma->vm_file and offset on the DMA mapping. > > > Let's split the patch into two. > > 1) opaque pointer > 2) vma stuffs > OK. >

Re: Re: [RFC v3 05/11] vdpa: shared virtual addressing support

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 1:55 PM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > This patches introduces SVA (Shared Virtual Addressing) > > support for vDPA device. During vDPA device allocation, > > vDPA device driver needs to indicate whether SVA is > > supported by the devic

  1   2   3   4   >