Re: switchdev fib offload issues

2016-04-21 Thread Roopa Prabhu
On 4/18/16, 10:17 AM, Hannes Frederic Sowa wrote: > Hi Jiri, > > On 18.04.2016 17:47, Jiri Pirko wrote: >> Proposed solutions (ideas): >> 1) per-netns. Add a procfs file: >> /proc/sys/net/ipv4/route/fib_offload_error_policy >> with values: "evict" - default, current behaviour >>

Re: switchdev fib offload issues

2016-04-19 Thread Jiri Pirko
Mon, Apr 18, 2016 at 07:52:27PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 18 Apr 2016 17:47:57 +0200 > >> However, if for any reason the switchdev add operation fails, there is an >> abort function called (switchdev_fib_ipv4_abort). This function does two >> things which are b

Re: switchdev fib offload issues

2016-04-19 Thread Jiri Pirko
Mon, Apr 18, 2016 at 06:59:37PM CEST, d...@cumulusnetworks.com wrote: >On 4/18/16 9:47 AM, Jiri Pirko wrote: >>Proposed solutions (ideas): >>1) per-netns. Add a procfs file: >> /proc/sys/net/ipv4/route/fib_offload_error_policy >>with values: "evict" - default, current behaviour >>

Re: switchdev fib offload issues

2016-04-18 Thread David Miller
From: Jiri Pirko Date: Mon, 18 Apr 2016 17:47:57 +0200 > However, if for any reason the switchdev add operation fails, there is an > abort function called (switchdev_fib_ipv4_abort). This function does two > things which are both unfortunate in many usecases: > 1) evicts all fib entries from HW l

Re: switchdev fib offload issues

2016-04-18 Thread Hannes Frederic Sowa
Hi Jiri, On 18.04.2016 17:47, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user

Re: switchdev fib offload issues

2016-04-18 Thread David Ahern
On 4/18/16 10:38 AM, Ilan Tayari wrote: Hi Jiri, Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP ad

Re: switchdev fib offload issues

2016-04-18 Thread David Ahern
On 4/18/16 9:47 AM, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user The pol

RE: switchdev fib offload issues

2016-04-18 Thread Ilan Tayari
Hi Jiri, > Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP address is added to an interface, so in suc