Re: do a single memdup_user in sctp_setsockopt v2

2020-07-20 Thread Marcelo Ricardo Leitner
On Sun, Jul 19, 2020 at 06:27:27PM -0700, David Miller wrote: > From: Christoph Hellwig > Date: Sun, 19 Jul 2020 09:21:37 +0200 > > > here is a resend of my series to lift the copy_from_user out of the > > individual sctp sockopt handlers into the main sctp_setsockopt > > routine. > > > > Change

Re: do a single memdup_user in sctp_setsockopt v2

2020-07-19 Thread David Miller
From: Christoph Hellwig Date: Sun, 19 Jul 2020 09:21:37 +0200 > here is a resend of my series to lift the copy_from_user out of the > individual sctp sockopt handlers into the main sctp_setsockopt > routine. > > Changes since v1: > - fixes a few sizeof calls. > - use memzero_explicit in sctp_s

Re: do a single memdup_user in sctp_setsockopt

2020-05-25 Thread Marcelo Ricardo Leitner
On Sat, May 23, 2020 at 09:19:29AM +0200, 'Christoph Hellwig' wrote: > On Fri, May 22, 2020 at 11:36:23AM -0300, Marcelo Ricardo Leitner wrote: ... > > What if you two work on a joint patchset for this? The proposals are > > quite close. The differences around the setsockopt handling are > > minima

Re: do a single memdup_user in sctp_setsockopt

2020-05-25 Thread Marcelo Ricardo Leitner
On Mon, May 25, 2020 at 07:37:49PM +, David Laight wrote: > I'm going to post a V3 of my big patch - I spotted an error. > I'll include a different (smaller) patch in 0/1 that generates > exactly the same object code but is easier to review. Please make sure to split at least setsockopt and ge

RE: do a single memdup_user in sctp_setsockopt

2020-05-25 Thread David Laight
From: 'Christoph Hellwig' > Sent: 23 May 2020 08:19 ... > Alternatively I'll also happily only do a partial conversion for what > I need for the kernel_setsockopt removal and let you and Dave decided > what you guys prefer for the rest. I presume the justification for removing kernel_[sg]etsockopt

Re: do a single memdup_user in sctp_setsockopt

2020-05-23 Thread 'Christoph Hellwig'
On Fri, May 22, 2020 at 11:36:23AM -0300, Marcelo Ricardo Leitner wrote: > It's subjective, yes, but we hardly have patches over 5k lines. > In the case here, as changing the functions also requires changing > their call later on the file, it helps to be able to check that is was > properly updated

Re: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread David Miller
From: Christoph Hellwig Date: Thu, 21 May 2020 19:46:35 +0200 > based on the review of Davids patch to do something similar I dusted off > the series I had started a few days ago to move the memdup_user or > copy_from_user from the inidividual sockopts into sctp_setsockopt, > which is done with o

RE: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 22 May 2020 15:36 > > On Fri, May 22, 2020 at 08:02:09AM +, David Laight wrote: > > From: Christoph Hellwig > > > Sent: 21 May 2020 18:47 > > > based on the review of Davids patch to do something similar I dusted off > > > the series I had started a few da

Re: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread Marcelo Ricardo Leitner
On Fri, May 22, 2020 at 08:02:09AM +, David Laight wrote: > From: Christoph Hellwig > > Sent: 21 May 2020 18:47 > > based on the review of Davids patch to do something similar I dusted off > > the series I had started a few days ago to move the memdup_user or > > copy_from_user from the inidivi

RE: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread David Laight
From: Christoph Hellwig > Sent: 21 May 2020 18:47 > based on the review of Davids patch to do something similar I dusted off > the series I had started a few days ago to move the memdup_user or > copy_from_user from the inidividual sockopts into sctp_setsockopt, > which is done with one patch per o